Function pointer cast in test_imp

[hoodmane]

BPO	47196
Nosy	@tiran, @miss-islington, @hoodmane, @hoodmane
PRs	bpo-47196: Fix function pointer cast in test_imp #32244 bpo-47196: Fix one more PyInit function signature #32280

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-04-03.21:01:24.653>
created_at = <Date 2022-04-02.00:01:51.149>
labels = ['type-feature', 'tests', '3.11']
title = 'Function pointer cast in test_imp'
updated_at = <Date 2022-04-03.21:01:24.652>
user = 'https://github.com/hoodmane'

bugs.python.org fields:

activity = <Date 2022-04-03.21:01:24.652>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2022-04-03.21:01:24.653>
closer = 'christian.heimes'
components = ['Tests']
creation = <Date 2022-04-02.00:01:51.149>
creator = 'hoodchatham'
dependencies = []
files = []
hgrepos = []
issue_num = 47196
keywords = ['patch']
message_count = 4.0
messages = ['416524', '416525', '416540', '416614']
nosy_count = 4.0
nosy_names = ['christian.heimes', 'miss-islington', 'hoodmane', 'hoodchatham']
pr_nums = ['32244', '32280']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue47196'
versions = ['Python 3.11']

[hoodmane]

The function PyInit_imp_dummy is declared as void f(PyObject* spec) and ignores the argument. In the test, it is called via imp.load_dynamic as void f(void). On wasm targets without the call trampolines added in
https://bugs.python.org/issue47162
this causes a fatal error. (There's a bit more discussion about this issue in that thread.)

[hoodmane]

Every other PyInit function in that module also needs the spec argument to be removed in order for test_importlib to pass.

[miss-islington]

New changeset 7000cd7 by Hood Chatham in branch 'main':
bpo-47196: Fix function pointer cast in test_imp (GH-32244)
7000cd7

[miss-islington]

New changeset 3faa9f7 by Hood Chatham in branch 'main':
bpo-47196: Fix one more PyInit function signature (GH-32280)
3faa9f7