Backport memoryview object to Python 2.7

[teoliphant]

BPO	2396
Nosy	@akuchling, @brettcannon, @theller, @pitrou, @benjaminp
Files	memview-trunk.patch memview-trunk2.patch memview-trunk3.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/pitrou'
closed_at = <Date 2009-04-02.21:21:31.889>
created_at = <Date 2008-03-18.16:02:42.942>
labels = ['interpreter-core', 'type-feature']
title = 'Backport memoryview object to Python 2.7'
updated_at = <Date 2009-04-02.21:21:31.888>
user = 'https://bugs.python.org/teoliphant'

bugs.python.org fields:

activity = <Date 2009-04-02.21:21:31.888>
actor = 'pitrou'
assignee = 'pitrou'
closed = True
closed_date = <Date 2009-04-02.21:21:31.889>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2008-03-18.16:02:42.942>
creator = 'teoliphant'
dependencies = []
files = ['12676', '12679', '13325']
hgrepos = []
issue_num = 2396
keywords = ['patch']
message_count = 11.0
messages = ['63930', '70648', '70710', '70711', '70738', '70741', '79559', '79570', '82585', '83540', '85267']
nosy_count = 6.0
nosy_names = ['akuchling', 'brett.cannon', 'theller', 'teoliphant', 'pitrou', 'benjamin.peterson']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = 'patch review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue2396'
versions = ['Python 2.7']

[teoliphant]

The memoryview object in Python 2.6 would help in the transition to
Python 3.0. It is a lower-priority and could wait until 2.7 if it
doesn't get finished.

[brettcannon]

But the warning in 2.6 for buffer() says to use memoryview(), which does
not exist. So either the backport needs to happen in 2.6 or the warning
needs to go away for generic buffer() usage and instead be changed to
only occur when the 2to3 fixer won't work (which, I am guessing, is only
needed when more than one argument to buffer() is used).

[akuchling]

Is there still time to do the backport for 2.6 at this late date?

[pitrou]

Not only there may not be enough time, but:

1. the memoryview implementation itself is not finished (that is, in py3k)
2. polishing and documenting the buffer API is more important
3. there doesn't seem to be any use for memoryview objects right now

So, IMO, this can be re-targeted to 2.7.

[benjaminp]

I concur.

[pitrou]

Not a release blocker then :-)

[pitrou]

Here is a patch. Some remarks:

• I had to disable a few tests in test_memoryview.py, mainly because
  array.array does not support the new buffer API in 2.x
• I kept the PyBytes_* aliases in memoryobject.c rather than using the
  PyString_* equivalents. Is it ok?
• I didn't update the Windows build files, I suppose someone else can do
  it (I'm unable to do it myself)
• I'm not sure about the tp_flags juggling in typeobject.c, my additions
  may be redundant (although very lightweight)

[pitrou]

This new patch includes documentation update and fixes as well.

[benjaminp]

Some comments:

• PyBytes_* API is fine.
• memory_str should die.
• Py_TPFLAGS_HAVE_NEWBUFFER needs to be documented.

Otherwise it looks good.