Patch cElementTree to export CurrentLineNumber

[robinbryce2]

BPO	1538691
Nosy	@birkenfeld, @florentx
Superseder	bpo-6472: Update ElementTree with upstream changes
Files	patch_against_51208.diff: [PATCH] pyexpat.c, _elementtree.c & test_xml_etree_c.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-03-11.14:49:26.677>
created_at = <Date 2006-08-11.13:27:12.000>
labels = ['expert-XML', 'type-feature']
title = 'Patch cElementTree to export CurrentLineNumber'
updated_at = <Date 2010-03-11.14:49:26.675>
user = 'https://bugs.python.org/robinbryce2'

bugs.python.org fields:

activity = <Date 2010-03-11.14:49:26.675>
actor = 'flox'
assignee = 'effbot'
closed = True
closed_date = <Date 2010-03-11.14:49:26.677>
closer = 'flox'
components = ['XML']
creation = <Date 2006-08-11.13:27:12.000>
creator = 'robinbryce2'
dependencies = []
files = ['7460']
hgrepos = []
issue_num = 1538691
keywords = ['patch']
message_count = 6.0
messages = ['50868', '50869', '85282', '85482', '86120', '100859']
nosy_count = 6.0
nosy_names = ['effbot', 'nnorwitz', 'georg.brandl', 'robinbryce2', 'robinbryce', 'flox']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = '6472'
type = 'enhancement'
url = 'https://bugs.python.org/issue1538691'
versions = ['Python 2.7', 'Python 3.2']

[robinbryce2]

This patch provides to the 'current' position expat api
via cElementTree.XMLTreeBuilder.

pyexpat already exposes this via the attributes
CurrentLineNumber, CurrentColumnNumber and
CurrentByteIndex. In order for cElementTree to do the
same, the following expat functions are added to those
exported via the pyexpat capi:

• XML_CurrentLineNumber
• XML_CurrentColumnNumber
• XML_CurrentByteIndex

Then, in _elementtree.c, the xmlparser_getattr is made
to mirror the provisions made in pyexpat. A trivial
test is added to test_etree_c.py to cover the three new
attributes.

This patch was motivated by a discussion[1] on the
turbogears list that referenced two xml templating
libraries Kid & Markup. One of the benefits of the
latter is the ability to report line numbers for
template source errors.

If this patch is applied it should be possible for Kid,
and anything else that uses cElementTree for
xmlparsing, to do the same.

[1]
http://groups.google.com/group/turbogears/browse_frm/thread/1ed59ed984fc8bbe/1f06eb00e83f93d9#1f06eb00e83f93d9

[nnorwitz]

Logged In: YES
user_id=33168

Fredrik, do you want etree patches here?

[effbot]

In the upstream 1.0.6, the ParseError exception has a position attribute
that contains a (line, column) tuple.

[birkenfeld]

Which will be synced into core at some point, I guess?

[robinbryce]

In the upstream 1.0.6, the ParseError exception has a position attribute
that contains a (line, column) tuple.

That's fine for errors in the xml domain. Its not enough if I'm
reporting errors in the application domain - where I wont have a handy
exception to interrogate. What's the problem with just exposing the api
and requiring users who need it to use the streaming parser ?

Personally, I would have cached these details as a properties of the
_ElementInterface implementation for precisely this use case.

[florentx]

ElementTree fixed in 2.7. See bpo-6472.