Close PRs that try to merge a user's maintenance branch into master#70
Merged
Conversation
Close PR that tries to merge the user's maintenance branch into CPython's master.
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 923 931 +8
Branches 55 55
=====================================
+ Hits 923 931 +8
Continue to review full report at Codecov.
|
brettcannon
changed the title
brettcannon
approved these changes
Nov 15, 2017
Member
|
Obviously keep a close eye on this one once you merge to make sure it doesn't over-reach. |
Member
Author
|
Thanks! |
Member
Author
|
Sorry!! I broke things, as seen in python/cpython#4409 🙇♀️ Will write another test case and a PR soon. |
Member
|
I had a feeling that regex might be too permissive. 😄 It's okay, I've just gone ahead and rolled back on Heroku to the last version so there's no rush. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close PR that tries to merge the user's maintenance branch into CPython's master.
This will close PR like python/cpython#4266.