Skip to content

[full-ci] Redesign switch icons to RemixIcons#6142

Merged
kulmann merged 2 commits into
masterfrom
redesign-switch-to-remixicons
Jan 4, 2022
Merged

[full-ci] Redesign switch icons to RemixIcons#6142
kulmann merged 2 commits into
masterfrom
redesign-switch-to-remixicons

Conversation

@lookacat

@lookacat lookacat commented Dec 13, 2021 •
edited by pascalwengerter
Loading

Copy link
Copy Markdown
Contributor

Description

We've changed the available icons in the ownCloud design system in owncloud/owncloud-design-system#1826 and owncloud/owncloud-design-system#1853

This PR contains the necessary adjustments in web for switching the icon set

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@update-docs

update-docs Bot commented Dec 13, 2021

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

pascalwengerter
pascalwengerter reviewed Dec 13, 2021
View reviewed changes
Comment thread package.json Outdated
kulmann
kulmann suggested changes Dec 13, 2021
View reviewed changes

@kulmann kulmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided (in a call, with you ;-) ) that we
a) only include the fill icons for now
b) don't reference the -fill suffix in the icon name

This means for now, that the OcIcon component should automatically append -fill to the provided icon name and you have to remove all the -fill suffixes from this PR again.

@lookacat lookacat force-pushed the redesign-switch-to-remixicons branch 6 times, most recently from 166335e to 4a0d089 Compare December 14, 2021 09:18
@lookacat lookacat force-pushed the redesign-switch-to-remixicons branch from 119af14 to 36f1da8 Compare December 22, 2021 15:30
@lookacat lookacat marked this pull request as ready for review December 22, 2021 15:30
@lookacat lookacat requested a review from fschade as a code owner December 22, 2021 15:30
@lookacat lookacat force-pushed the redesign-switch-to-remixicons branch 2 times, most recently from 0b8fad1 to 3e0ced7 Compare December 30, 2021 18:16
@pascalwengerter pascalwengerter force-pushed the redesign-switch-to-remixicons branch from 44a6dc0 to 1bd9747 Compare December 30, 2021 22:29
@lookacat @pascalwengerter
change icons
b4e8a8a 
fix share indicators, add changelog

update file extension icons

fix filltype in sidebar

fix unittests, snapshots

add owncloud theme icons

move icons to general assets

fix icons path missing for oc10

fix missing icons

fix snapshot tests

fix linting

fix unittests

change ods version to alpha6

fix snapshot tests

change icon names for unittest

Fix ResourceTable tests relying on composition API

Fix integration link datepicker test, update changelog

Fix link expiration unit test
@pascalwengerter pascalwengerter force-pushed the redesign-switch-to-remixicons branch 2 times, most recently from 456fbd4 to 09712d2 Compare January 3, 2022 12:28
@ownclouders

ownclouders commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/21494/37/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

pascalwengerter
pascalwengerter reviewed Jan 3, 2022
View reviewed changes

@pascalwengerter pascalwengerter left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needs owncloud/owncloud-design-system#1853 to be merged & released
  • Also needs a check for icons from OC10 apps
  • Also needs changes to the Accounts&Settings services in oCIS which I'll prepare later today owncloud/ocis#2929
  • Needs fixing the CI since it's checking for SVGs to be present ☠️

@kulmann kulmann mentioned this pull request Jan 3, 2022
Merged
5 tasks
@pascalwengerter pascalwengerter changed the title Redesign switch icons to RemixIcons [full-ci] Redesign switch icons to RemixIcons Jan 3, 2022
@ownclouders

ownclouders commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21512/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders

ownclouders commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/21512/37/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@ownclouders

ownclouders commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/21512/64/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

fschade
fschade approved these changes Jan 3, 2022
View reviewed changes

@fschade fschade left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞 LGTM

@pascalwengerter pascalwengerter force-pushed the redesign-switch-to-remixicons branch from 8566bf5 to 70abd98 Compare January 3, 2022 18:08
@sonarqubecloud

sonarqubecloud Bot commented Jan 3, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@ownclouders

ownclouders commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21513/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@pascalwengerter pascalwengerter mentioned this pull request Jan 3, 2022
Closed
1 task
@ownclouders

ownclouders commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/21513/56/1
The following scenarios passed on retry:

  • webUIMarkdownEditor/markdownFile.feature:21

pascalwengerter
pascalwengerter reviewed Jan 3, 2022
View reviewed changes

@pascalwengerter pascalwengerter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still occasions where 'questionnaire-line' gets used but I wasn't able to understand when/where they'd get rendered 🤔 but happy to merge this PR (won't approve since half the changes came from my hand, after all) first and take care of those later

@pascalwengerter pascalwengerter mentioned this pull request Jan 3, 2022
Merged
9 tasks
kulmann
kulmann approved these changes Jan 4, 2022
View reviewed changes

@kulmann kulmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, icons are not perfectly picked and @tbsbdr will come up with individual icon replacements in a dedicated PR after this PR is merged.

@kulmann kulmann merged commit d256191 into master Jan 4, 2022
@delete-merged-branch delete-merged-branch Bot deleted the redesign-switch-to-remixicons branch January 4, 2022 09:45
ownclouders pushed a commit that referenced this pull request Jan 4, 2022
@kulmann
commit d256191
1fc1453 
Merge: 0ae22ad 70abd98
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Tue Jan 4 10:45:14 2022 +0100

    Merge pull request #6142 from owncloud/redesign-switch-to-remixicons

    [full-ci] Redesign switch icons to RemixIcons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

+2 more reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade fschade approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lookacat @ownclouders @kulmann @pascalwengerter @fschade