Skip to content

Revert "Revert "fix: on rejected shares no activities are reported to…#41078

Merged
DeepDiver1975 merged 4 commits into
masterfrom
revert-40454-revert-40421-fix/no-activity-on-rejected-shares
Nov 14, 2023
Merged

Revert "Revert "fix: on rejected shares no activities are reported to…#41078
DeepDiver1975 merged 4 commits into
masterfrom
revert-40454-revert-40421-fix/no-activity-on-rejected-shares

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Nov 8, 2023

Copy link
Copy Markdown
Member

… this user any more (#40421)" (#40454)"

This reverts commit 8541356.

Description

Related Issue

Fixes https://github.com/owncloud/enterprise/issues/5417

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975

Copy link
Copy Markdown
Member Author

activity is finally green as well - owncloud/activity#1197

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that this is the current PR for implementing this, so should the changelog link to that?

Comment thread changelog/unreleased/40421 Outdated
Co-authored-by: Phil Davis <phil@jankaritech.com>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

94.1% 94.1% Coverage
0.0% 0.0% Duplication

@DeepDiver1975 DeepDiver1975 merged commit d492f17 into master Nov 14, 2023
@delete-merged-branch delete-merged-branch Bot deleted the revert-40454-revert-40421-fix/no-activity-on-rejected-shares branch November 14, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants