fix: Do not allow to set higher permissions on a federated share for …

[DeepDiver1975]

…a resource which was shared with limited permissions

Description

Related Issue

• Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

72.7% Coverage
0.0% Duplication

[phil-davis]

The code looks like it works fine.
I have suggested a change to the name of a function - I think that the current name is misleading (from my reading of the code)

[phil-davis]

This has been released in 10.12.2 with exactly the code here, which works fine.
I will merge this PR to master so that we get the same code in master
Then I will make a separate PR with my refactoring suggestions - those do not effect the functionality.