Adjust parameters for guzzle7#40652
Merged
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Member
Author
|
I don't think we need a changelog item for this. |
f42127b to
36d2c8a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
jnweiger
approved these changes
Feb 23, 2023
jnweiger
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Although I am half blind.
This was referenced Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Fixes some bugs caused by the guzzle upgrade
I assume this was left because the default behavior is to use OCM, not the old mechanism. With OCM, the parameters use "json", so there is no problem.
So it seems the only real bug, at least in core, is with the background job of the federation app. The other 2 shouldn't trigger.
Related Issue
#40649
Motivation and Context
Issue with the background job needs to be fixed. There is also comments that needs to be updated.
How Has This Been Tested?
Manually tested except the one for the HTTPHelper, which is a blind change.
Screenshots (if appropriate):
Types of changes
Checklist: