Remove dav.enable.tech_preview#36815
Merged
Merged
Conversation
micbar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #36815 +/- ##
============================================
+ Coverage 64.68% 64.69% +<.01%
+ Complexity 19122 19117 -5
============================================
Files 1269 1269
Lines 74779 74774 -5
Branches 1320 1320
============================================
+ Hits 48373 48376 +3
+ Misses 26018 26010 -8
Partials 388 388
Continue to review full report at Codecov.
|
phil-davis
force-pushed
the
remove-tech_preview
branch
from
c3979a9 to
c3443df
Compare
12 tasks
phil-davis
commented
Jan 24, 2020
| $ocVersion = SetupHelper::getSystemConfigValue('version'); | ||
| // dav.enable.tech_preview was used in some ownCloud versions before 10.4.0 | ||
| // only set it on those versions of ownCloud | ||
| if (\version_compare($ocVersion, '10.4.0') === -1) { |
Contributor
Author
There was a problem hiding this comment.
Note: I checked this locally to make sure we do not go down this path on the current core 10.4.0.1 version, and will go down this path on 10.3.*
Contributor
Author
|
@micbar the backend code changes are very simple. Artur has reviewed the test code changes. |
micbar
changed the title
micbar
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the new trashbin API and new public links API available by default.
Related doc PR owncloud/docs#2248
Related Issue
How Has This Been Tested?
CI
Types of changes
Checklist: