Skip to content

read the correct translations#35973

Merged
phil-davis merged 1 commit into
masterfrom
apply-bugfix/32012
Aug 2, 2019
Merged

read the correct translations#35973
phil-davis merged 1 commit into
masterfrom
apply-bugfix/32012

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

This language dropdown fix was previously applied to the "old" master in PR #32015
It never made it back to stable10. So therefore it never made it to the "new" master.

After a transifex update, the "new" master was observed to be "broken".

Related Issue

#32012
#35970

How Has This Been Tested?

In a local browser session.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Aug 2, 2019
@phil-davis phil-davis changed the title Fixes 32012 - read the correct translations read the correct translations Aug 2, 2019
@phil-davis

Copy link
Copy Markdown
Contributor Author

"random" drone issue https://drone.owncloud.com/owncloud/core/19922/162

error /drone/src/build/node_modules/phantomjs-prebuilt: Command failed.
Exit code: 1

I restarted drone.

@sharidas

sharidas commented Aug 2, 2019

Copy link
Copy Markdown
Contributor

"random" drone issue https://drone.owncloud.com/owncloud/core/19922/162

error /drone/src/build/node_modules/phantomjs-prebuilt: Command failed.
Exit code: 1

I restarted drone.

Again hit with the same error. Restarted drone.

@phil-davis phil-davis merged commit 88039b2 into master Aug 2, 2019
@delete-merged-branch delete-merged-branch Bot deleted the apply-bugfix/32012 branch August 2, 2019 10:41
@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants