Handle exception properly when deleting trash items#35879
Merged
DeepDiver1975 merged 1 commit intoJul 23, 2019
Conversation
10 tasks
DeepDiver1975
commented
Jul 19, 2019
14b0509 to
77a862f
Compare
Codecov Report
@@ Coverage Diff @@
## stable10 #35879 +/- ##
===============================================
- Coverage 65.09% 45.63% -19.46%
===============================================
Files 1302 116 -1186
Lines 77142 11519 -65623
Branches 1301 1301
===============================================
- Hits 50216 5257 -44959
+ Misses 26541 5877 -20664
Partials 385 385
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #35879 +/- ##
==============================================
+ Coverage 65.09% 65.1% +<.01%
- Complexity 20189 20197 +8
==============================================
Files 1302 1302
Lines 77142 77158 +16
Branches 1301 1301
==============================================
+ Hits 50216 50232 +16
Misses 26541 26541
Partials 385 385
Continue to review full report at Codecov.
|
77a862f to
c1ee30c
Compare
c1ee30c to
54bd6dc
Compare
jvillafanez
approved these changes
Jul 23, 2019
Member
Author
|
THX @jvillafanez |
10 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Any exception during deletion of an item from trashbin resulted in a 500 response.
Related Issue
Types of changes
Checklist:
Open tasks: