[BUG] Av. offline files removed locally with the Local only option

[Aitorbp]

Related Issues

App:#4353

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

Reports:

• (1) Sync operation does not sync files in a subfolder that were locally removed beforehand [BUG] Av. offline files removed locally with the Local only option #4399 (comment) [FIXED]

[JuancaG05]

Some changes and comments here for you to review @Aitorbp!

[Aitorbp]

Checks functionalities of deleteLocalFolderRecursively:

Case Delete files only local:

1. Create a folder with an available offline file and another downloaded file inside.
2. Delete the folder only local.
3. Check in Device Explorer that only the downloaded file has been deleted and both the parent folder and the available offline file are kept.

Case refresh on a folder that no longer exists:

1. Create a folder with available offline and downloaded files inside.
2. Delete the folder from the web.
3. Do a refresh in the main list.
4. Check that all files and also the available offline files have been deleted on that folder in Device Explorer

Case move folder with a source folder that no longer exists:

1. Create a folder with downloaded and available offline files.
2. Start the process of moving the folder.
3. Go to the web and delete the source folder.
4. End the move process.
5. Check Device Explorer to see if the entire source folder has been deleted.

If you move a folder to a destination folder that no longer exists:

1. Move a folder or file to a folder with available offline and downloaded files inside.
2. In the process of moving it, we delete the folder from the web.
3. We finish the process of moving the folder.
4. Check Device Explorer to see if the entire destination folder has been deleted

If you copy a folder from a source folder that no longer exists:

1. Create a folder with download and available offline files.
2. Start the process of copying the folder.
3. Go to the web and delete the source folder.
4. Check Device Explorer to see if the entire source folder has been deleted when the process is finished

If you copy a folder to a destination folder that no longer exists:

1. Copy a folder or file to a folder with available offline and downloaded files inside.
2. In the process of moving it, we delete the folder from the web.
3. We finish the process of moving the folder.
4. Check in Device Explorer if the entire destination folder has been deleted.

I leave you these test cases in case you want to try them when doing QA @jesmrec

[JuancaG05]

Some more things to check here @Aitorbp 👀

[JuancaG05]

One more change, and review as well the non-resolved comment of the previous CR round @Aitorbp

[JuancaG05]

@Aitorbp an explanation would be nice here, so that we can check it in the future if we forget

[JuancaG05]

Let's move this to QA 🚀

[jesmrec]

First, checks over #4402, that is merged into here

Folder with some files and a subfolders that also contains some files

Folder1
|_ File1
|_ File2
|_ Folder2
    |_ File3
    |_ File4

• Nothing downloaded + Av. offline + Unset av. offline -> Everything downloaded
• File1 & File2 downloaded + remove locally File2 + Av. offline + Unset av. offline -> Everything downloaded
• File3 & File4 downloaded + remove locally File3 + Av. offline + Unset av. offline -> Everything downloaded
• File1 & File3 downloaded + remove locally File3 + Av. offline + Unset av. offline -> Everything downloaded
• File1 & File3 downloaded + remove locally File3 & File1 + Av. offline + Unset av. offline -> Everything downloaded
• Everything downloaded + remove everything locally + Av. offline + Unset av. offline -> Everything downloaded

[jesmrec]

Basic behaviour:

Remove folder dialog when...:

• Nothing is downloaded inside -> Local only not displayed in dialog
• Some files are dowloaded and others are not downloaded -> Local only displayed in dialog
• Some files are downloaded and others are av. offline -> Local only displayed in dialog
• Some files are av. offline and others are not downloaded -> Local only not displayed in dialog
• Everything is downloaded -> Local only displayed in dialog
• Everything is av. offline -> Local only not displayed in dialog

All those tests were repeated with files inside a subfolder.

Local copies of the items removed externally:

• Remove file from server -> locally removed
• Remove folder from server -> locally removed including local copies
• Remove folder during copy/move operations -> locally removed including local copies

[jesmrec]

(1) [FIXED]

I noticed the bad behaviour when a sync is performed (not an av. offline);

With the following structure:

Folder with some files and a subfolders that also contains some files

Folder1
|_ File1
|_ File2
|_ Folder2
    |_ File3
    |_ File4

1. Download File3
2. Remove locally File3
3. Sync Folder1
4. Browse to Folder2

Current:

File3 and File 4 are not downloaded.

Expected:

Both File3 and File4 are downloaded, because their parent folder was synced in the previous step.

That was the problem fixed in #4402 from the av. offline files, that seems to be reproducible with sync.

Pixel 2, Android 11
62a76c55

[jesmrec]

Approved on my side.