[FEATURE REQUEST] Thumbnail improvements in grid view#4237
Merged
Conversation
9 tasks
JuancaG05
requested changes
Nov 30, 2023
Aitorbp
force-pushed
the
feature/thumbnail_improvements_grid_view
branch
from
f3e31c0 to
7e8af8d
Compare
JuancaG05
approved these changes
Dec 4, 2023
JuancaG05
left a comment
JuancaG05
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Let's move this on to QA 🚀
Contributor
(1)Checking with many files, seems that not all are rendered correctly, and some of them are shown in the previous way. Check the following video out with ~100 heic files that does not have server-thumbnail: Screen_recording_20231205_165756.mp4I caught some logs: owncloud.2023-12-05_16.57.05.log Pixel2, Android11 |
Contributor
|
Problem reported here to be addressed in new issue. |
Aitorbp
force-pushed
the
feature/thumbnail_improvements_grid_view
branch
from
0cf8682 to
edb8f66
Compare
Aitorbp
added a commit
that referenced
this pull request
Feb 5, 2024
…_grid_view [FEATURE REQUEST] Thumbnail improvements in grid view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #4145
QA