🔍 Deep Dive: [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space" by Aitorbp · Pull Request #4160 · owncloud/android · GitHub

Aitorbp · 2023-09-19T08:41:18Z

Related Issues

Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Test Plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.2/Share%20with%20oC%20with%20spaces.md

Bugs & improvements:

(1) Glitch browsing through spaces in picker [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space" #4160 (comment) [FIXED]
(2) Crash when cancelling after browsing through spaces in picker [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space" #4160 (comment) [FIXED]
(3) No files in here placeholder's position [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space" #4160 (comment) [FIXED]
(4) Not posible to browse up in oC10's picker [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space" #4160 (comment) [FIXED]
(5) Crash when changing orientation in picker [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space" #4160 (comment) [FIXED]
(6) List of spaces in the account picker does not switch [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space" #4160 (comment) [FIXED]
(7) List of spaces missing after switching from oC10 account [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space" #4160 (comment) [FIXED]

JuancaG05

Nice job @Aitorbp! Some comments here for you to review 🚀

JuancaG05

Some more changes here @Aitorbp! 👍

JuancaG05

LGTM! Let's move this on 🚀

jesmrec · 2023-09-27T10:23:35Z

(1) [FIXED]

Create new space in oCIS account, and let it empty
Open a 3rd party app and share content with oC, browsing to the new space without submitting
Browse back to the list of spaces

Current: glitch in the view, No files here on the top:

Screen_recording_20230927_122234.mp4

Expected: just the list of spaces

Pixel 2, Android 11
d64538e7

jesmrec · 2023-09-27T10:37:42Z

(2) [FIXED]

Repeating the steps of 1. and then, clicking on Cancel, app crashes:

Process: com.owncloud.android.debug, PID: 18751
java.lang.IllegalArgumentException: Wrong element clicked at com.owncloud.android.ui.activity.ReceiveExternalFilesActivity.onClick(ReceiveExternalFilesActivity.java:503)
at android.view.View.performClick(View.java:7448)
at android.view.View.performClickInternal(View.java:7425)
at android.view.View.access$3600(View.java:810)
at android.view.View$PerformClick.run(View.java:28305)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:223)
at android.app.ActivityThread.main(ActivityThread.java:7656)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

i've noticed that the involved code is not new, but not reproducible with older versions because view did not exist

Pixel 2, Android 11
d64538e7

jesmrec · 2023-09-27T10:47:10Z

(3) [FIXED]

Placeholder for No files here has change position from center-alligned to top-alligned. Intended?

`4.1`	Current

Pixel 2, Android 11
d64538e7

jesmrec · 2023-09-27T11:37:40Z

(4) [FIXED]

Share any file with oC10, in a non-root folder and submit it
Share other file to the same location -> location is shown in the picker

Current: Not posible to browse up in the folder structure
Expected: Browsing in posible in all directions

Pixel 2, Android 11
d64538e7

jesmrec · 2023-09-27T12:18:01Z

(5) [FIXED]

this one does not seems to be directly related with the developed feature, but it's not reproducible in the current master and reproducible in the branch. Something related with the picker causing kind of regression.

Open an oCIS account
Select any item and Copy -> picker is displayed
Change device orientation

Current: app crashes

Process: com.owncloud.android.debug, PID: 22795
                                             java.lang.RuntimeException: Unable to start activity ComponentInfo{com.owncloud.android.debug/com.owncloud.android.ui.activity.FolderPickerActivity}: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment com.owncloud.android.presentation.spaces.SpacesListFragment: could not find Fragment constructor
                                             	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3449)
                                             	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601)
                                             	at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5456)
                                             	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:5362)
                                             	at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69)
                                             	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                             	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                             	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
                                             	at android.os.Handler.dispatchMessage(Handler.java:106)
                                             	at android.os.Looper.loop(Looper.java:223)
                                             	at android.app.ActivityThread.main(ActivityThread.java:7656)
                                             	at java.lang.reflect.Method.invoke(Native Method)
                                             	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
                                             	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
                                             Caused by: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment com.owncloud.android.presentation.spaces.SpacesListFragment: could not find Fragment constructor
                                             	at androidx.fragment.app.Fragment.instantiate(Fragment.java:681)
                                             	at androidx.fragment.app.FragmentContainer.instantiate(FragmentContainer.java:57)
                                             	at androidx.fragment.app.FragmentManager$3.instantiate(FragmentManager.java:507)
                                             	at androidx.fragment.app.FragmentState.instantiate(FragmentState.java:81)
                                             	at androidx.fragment.app.FragmentStateManager.<init>(FragmentStateManager.java:85)
                                             	at androidx.fragment.app.FragmentManager.restoreSaveStateInternal(FragmentManager.java:2507)
                                             	at androidx.fragment.app.FragmentManager.attachController(FragmentManager.java:2667)
                                             	at androidx.fragment.app.FragmentController.attachHost(FragmentController.java:117)
                                             	at androidx.fragment.app.FragmentActivity.lambda$init$3$androidx-fragment-app-FragmentActivity(FragmentActivity.java:140)
                                             	at androidx.fragment.app.FragmentActivity$$ExternalSyntheticLambda3.onContextAvailable(Unknown Source:2)
                                             	at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99)
                                             	at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352)
                                             	at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217)
                                             	at com.owncloud.android.ui.activity.DrawerActivity.onCreate(DrawerActivity.kt:581)
                                             	at com.owncloud.android.ui.activity.FileActivity.onCreate(FileActivity.java:118)
                                             	at com.owncloud.android.ui.activity.FolderPickerActivity.onCreate(FolderPickerActivity.kt:58)
                                             	at android.app.Activity.performCreate(Activity.java:8000)
                                             	at android.app.Activity.performCreate(Activity.java:7984)
                                             	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
                                             	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3422)
                                             	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601) 
                                             	at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5456) 
                                             	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:5362) 
                                             	at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69) 
                                             	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 
                                             	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 
                                             	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066) 
                                             	at android.os.Handler.dispatchMessage(Handler.java:106) 
                                             	at android.os.Looper.loop(Looper.java:223) 
                                             	at android.app.ActivityThread.main(ActivityThread.java:7656) 
                                             	at java.lang.reflect.Method.invoke(Native Method) 
                                             	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
                                             	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) 
                                             Caused by: java.lang.NoSuchMethodException: com.owncloud.android.presentation.spaces.SpacesListFragment.<init> []
                                             	at java.lang.Class.getConstructor0(Class.java:2332)
                                             	at java.lang.Class.getConstructor(Class.java:1728)
                                             	at androidx.fragment.app.Fragment.instantiate(Fragment.java:666)
                                             	at androidx.fragment.app.FragmentContainer.instantiate(FragmentContainer.java:57) 
                                             	at androidx.fragment.app.FragmentManager$3.instantiate(FragmentManager.java:507) 
                                             	at androidx.fragment.app.FragmentState.instantiate(FragmentState.java:81) 
                                             	at androidx.fragment.app.FragmentStateManager.<init>(FragmentStateManager.java:85) 
                                             	at androidx.fragment.app.FragmentManager.restoreSaveStateInternal(FragmentManager.java:2507) 
                                             	at androidx.fragment.app.FragmentManager.attachController(FragmentManager.java:2667) 
                                             	at androidx.fragment.app.FragmentController.attachHost(FragmentController.java:117) 
                                             	at androidx.fragment.app.FragmentActivity.lambda$init$3$androidx-fragment-app-FragmentActivity(FragmentActivity.java:140) 
                                             	at androidx.fragment.app.FragmentActivity$$ExternalSyntheticLambda3.onContextAvailable(Unknown Source:2) 
                                             	at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99) 
                                             	at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352) 
                                             	at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217) 
                                             	at com.owncloud.android.ui.activity.DrawerActivity.onCreate(DrawerActivity.kt:581) 
                                             	at com.owncloud.android.ui.activity.FileActivity.onCreate(FileActivity.java:118) 
                                             	at com.owncloud.android.ui.activity.FolderPickerActivity.onCreate(FolderPickerActivity.kt:58) 
                                             	at android.app.Activity.performCreate(Activity.java:8000) 
                                             	at android.app.Activity.performCreate(Activity.java:7984) 
                                             	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309) 
                                             	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3422) 
                                             	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601) 
                                             	at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5456) 
                                             	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:5362) 
                                             	at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69) 
                                             	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 
                                             	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 
                                             	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066) 
                                             	at android.os.Handler.dispatchMessage(Handler.java:106) 
                                             	at android.os.Looper.loop(Looper.java:223) 
                                             	at android.app.ActivityThread.main(ActivityThread.java:7656) 
                                             	at java.lang.reflect.Method.invoke(Native Method) 
                                             	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
                                             	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

Expected: no crash.

Pixel 2, Android 11
d64538e7

JuancaG05

LGTM, we can keep on with QA @jesmrec

jesmrec · 2023-09-29T07:48:11Z

(6) [FIXED]

Add two oCIS accounts with different spaces' list
Share something with oC from a 3rd party app -> list of accounts is displayed, the list of spaces of one of them is listed in the background
In the account picker, select the other one

Current: the list of spaces does not change and is displayed the list of the incorrect account
Expected: the list of spaces is correct

Pixel 2, Android 11
7fe02775

jesmrec · 2023-09-29T10:24:53Z

(7) [FIXED]

This one may be the same as (6) but i'm not totally sure, so, if it is finally the same just ignore it

Add an oC10 account and an oCIS account to the device
Share something with the oC10 account from a 3rd party app
Share again with oC, but now select the oCIS account (the oC10 file list was in the background because it was selected in step 2.)

Current: list of spaces empty with error Spaces could not be refreshed because it was not found
Expected: list of spaces displayed

Screen_recording_20230929_124837.mp4

Pixel 2, Android 11
Samsung Galaxy A8, Android 13
7fe02775

jesmrec · 2023-10-03T12:07:12Z

Approved on my side. Great job!

…pload_personal_space_1 [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space"

Aitorbp self-assigned this Sep 19, 2023

Aitorbp linked an issue Sep 19, 2023 that may be closed by this pull request

[FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space" #4088

Closed

JuancaG05 requested changes Sep 21, 2023

View reviewed changes

JuancaG05 self-requested a review September 22, 2023 07:45

JuancaG05 requested changes Sep 22, 2023

View reviewed changes

Aitorbp requested a review from JuancaG05 September 25, 2023 06:46

JuancaG05 approved these changes Sep 27, 2023

View reviewed changes

Aitorbp requested a review from JuancaG05 September 28, 2023 07:01

JuancaG05 approved these changes Sep 29, 2023

View reviewed changes

Aitorbp requested a review from JuancaG05 October 2, 2023 07:17

JuancaG05 approved these changes Oct 3, 2023

View reviewed changes

jesmrec added the Approved by qa label Oct 3, 2023

Aitorbp and others added 10 commits October 4, 2023 07:40

Share with spaces functionality

3af32b3

Added calens

0729e34

Calens changelog updated

ce30eae

Added more functionalities

fd8b0c5

Corrections from CR

ac50506

Calens changelog updated

76bb242

Corrections from CR 2

8cc4446

Some fix

3b4d295

Some fix from QA

bb3145e

Fix QA - changed parameter accountName

f3cdfc4

Aitorbp added 4 commits October 4, 2023 07:54

Fix accountName

55dafd4

Added a newInstance for calling the fragment

0fff5da

Deleted variables

52984b4

Fix from rebase

5dbd19d

Aitorbp force-pushed the feature/share_to_allows_only_upload_personal_space_1 branch from 1827367 to 5dbd19d Compare October 4, 2023 07:02

Aitorbp merged commit 0f3ee6f into master Oct 4, 2023

Aitorbp deleted the feature/share_to_allows_only_upload_personal_space_1 branch October 4, 2023 07:23

jesmrec pushed a commit that referenced this pull request Oct 20, 2023

Merge pull request #4160 from owncloud/feature/share_to_allows_only_u…

f78735d

…pload_personal_space_1 [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space"

Aitorbp added a commit that referenced this pull request Feb 5, 2024

Merge pull request #4160 from owncloud/feature/share_to_allows_only_u…

e740819

…pload_personal_space_1 [FEATURE REQUEST] OCIS: "Share to" allows only upload to personal "space"

Conversation

Aitorbp commented Sep 19, 2023 • edited by jesmrec Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

QA

Uh oh!

JuancaG05 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JuancaG05 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JuancaG05 left a comment

Choose a reason for hiding this comment

Uh oh!

jesmrec commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(1) [FIXED]

Uh oh!

jesmrec commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(2) [FIXED]

Uh oh!

jesmrec commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(3) [FIXED]

Uh oh!

jesmrec commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(4) [FIXED]

Uh oh!

jesmrec commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(5) [FIXED]

Uh oh!

JuancaG05 left a comment

Choose a reason for hiding this comment

Uh oh!

jesmrec commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(6) [FIXED]

Uh oh!

jesmrec commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(7) [FIXED]

Uh oh!

jesmrec commented Oct 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Aitorbp commented Sep 19, 2023 •

edited by jesmrec

Loading

jesmrec commented Sep 27, 2023 •

edited

Loading

jesmrec commented Sep 27, 2023 •

edited

Loading

jesmrec commented Sep 27, 2023 •

edited

Loading

jesmrec commented Sep 27, 2023 •

edited

Loading

jesmrec commented Sep 27, 2023 •

edited

Loading

jesmrec commented Sep 29, 2023 •

edited

Loading

jesmrec commented Sep 29, 2023 •

edited

Loading