chore(ci): validate README lists of keys#39
Merged
Merged
Conversation
Ensure README lists are in sync with nodejs/node README.
Member
|
I'm planning (tomorrow) to open PR's to update my email address. Is there going to be any issues around sequencing (e.g. I need to update my email in the main Node.js README first before updating it in this repository?)? |
Contributor
Author
|
As it is currently, if you open a PR here before the change has landed on nodejs/node, the CI will be red here. Once the change has landed on nodejs/node, restarting the CI here should be enough to turn it to green. |
Contributor
Author
|
@nodejs/releasers any chance I could get more reviews? Hopefully the README change itself is trivial to review, and the workflow should only increase our confidence that the two READMEs are in sync. I'm eager to see this move forward as it is blocking my other PRs. |
richardlau
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure README lists are in sync with nodejs/node README.