Added required UIRef for localized strings#8884
Closed
billti wants to merge 1 commit into
Closed
Conversation
mscdex
added
windows
Member
|
Thanks! Do you mind changing the commit message?
|
Member
Contributor
Author
|
I've updated the commit msg. Not sure why the CI failed on an ARM build for Linux as this only touches the MSI installer for Windows... seems unrelated. |
Contributor
Author
|
ping... @fhinkel any thing else you need on this? |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999 to
83c7a88
Compare
Contributor
Author
|
This simple fix has been out a couple month... anything else needed here? |
Contributor
|
@nodejs/platform-windows |
joaocgreis
approved these changes
Dec 15, 2016
joaocgreis
left a comment
joaocgreis
left a comment
Member
There was a problem hiding this comment.
I can't reproduce the original issue as I don't have a non-english OS at hand, but the fix makes sense.
I've tested a MSI build with this on Windows 2008R2 and Windows 10 and did not see any issue.
Member
joaocgreis
pushed a commit
that referenced
this pull request
Dec 20, 2016
Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: #8884
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 20, 2016
Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: nodejs#8884
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: #8884
MylesBorins
pushed a commit
that referenced
this pull request
Jan 22, 2017
Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: #8884
Contributor
|
@joaocgreis I've backported to v4 and v6, let me know if we should not land it. |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: #8884
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: #8884
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: #8884
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: #8884
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: #8884
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesDescription of change
Installing the latest builds on Windows, I noticed the installer was display incorrect strings for the status text on the progress page. Digging into this a little I found the root cause.
It appears localization work has started on the installer (even though still only for en-us at the moment). However a
UIRefelement required for localized errors and progress text is missing, causing the progress status messages (and others) in the installer to display the template string incorrectly.This fix simply adds the required
UIRefas outlined at the end of the doc page at http://wixtoolset.org/documentation/manual/v3/wixui/wixui_localization.html, or in the StackOverflow answer at http://stackoverflow.com/a/5986030/1674945 .Below shows the progress dialog before and after the change.
Before
After