⚡ Quick Guide: [v24.x][riscv] Fix check failed in bind_to by kxxt · Pull Request #60962 · nodejs/node · GitHub

kxxt · 2025-12-05T11:48:24Z

Backport two V8 commits to fix a crash found while building Adguard Home using webpack riscv-forks/electron#9.

This is only needed for v24.x.

The PR for the main branch(#58746) has missed its opportunity because now v8 version on v25.x and main already contains these fixes.

Close #60895

nodejs-github-bot · 2025-12-05T11:48:30Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

nodejs-github-bot · 2025-12-05T13:49:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70392/

nodejs-github-bot · 2025-12-05T13:49:55Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6900/

nodejs-github-bot · 2025-12-05T13:50:26Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6900/

nodejs-github-bot · 2025-12-05T13:52:12Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6900/

kxxt · 2025-12-06T01:23:02Z

node-test-commit-aix failure seems unrelated.
node-test-commit-arm failure is caused by transit network error.

Probably we should retry the CI.

nodejs-github-bot · 2025-12-06T01:46:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70395/

kxxt · 2025-12-06T07:37:17Z

Unfortunately, the aix CI failed again.

nodejs-github-bot · 2025-12-06T13:43:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70401/

kxxt · 2025-12-06T13:54:26Z

Could we skip or fix those flaky tests for aix CI instead of infinitely retrying it?
For reference, the set of tests that are flaky appears to be

addons.stringbytes-external-exceed-max.test-stringbytes-external-at-max
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-ascii
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-base64
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-binary 
addons.stringbytes-external-exceed-max.test-stringbytes-external-exceed-max-by-1-utf8

(Collected from a few recent failed runs)

kxxt · 2025-12-06T14:13:55Z

Rebased to fix conflict in v8_embedder_string

Temporarily disable on riscv64 due to build error with nodejs 24.x. ``` $ react-scripts build (node:54006) [DEP0176] DeprecationWarning: fs.F_OK is deprecated, use fs.constants.F_OK instead (Use `node --trace-deprecation ...` to show where the warning was created) Creating an optimized production build... [...] Fatal error in , line 0 Check failed: (trampoline_pos - fixup_pos) <= kMaxBranchOffset. FailureMessage Object: 0x3f8fbf5168 ----- Native stack trace ----- error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. >>> ERROR: alloy: build failed ``` See also: nodejs/node#60895 nodejs/node#60962

Temporarily disable on riscv64 due to build error with nodejs 24.x. ``` $ react-scripts build (node:6884) [DEP0176] DeprecationWarning: fs.F_OK is deprecated, use fs.constants.F_OK instead (Use `node --trace-deprecation ...` to show where the warning was created) Creating an optimized production build... [...] Fatal error in , line 0 Check failed: (trampoline_pos - fixup_pos) <= kMaxBranchOffset. FailureMessage Object: 0x3f91ffb168 ----- Native stack trace ----- error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. >>> ERROR: alloy: build failed ``` See also: nodejs/node#60895 nodejs/node#60962

sxa · 2025-12-08T11:35:27Z

Issue for the AIX failures. I think it's fair to assume these are not related to this PR specifically (and the fix to mark it flaky should be in v24.x-staging now).

nodejs-github-bot · 2025-12-08T12:48:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70422/

nodejs-github-bot · 2025-12-08T12:53:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70426/

github-actions · 2025-12-08T13:12:35Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - deps: V8: backport bbaae8e36164
   ⚠  - deps: V8: cherry-pick 394a8053b59e
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/20029272474

kxxt · 2025-12-08T13:13:55Z

It appears that we got another merge conflict. Let me rebase it.

Original commit message: Reland "[riscv] Fix Check failed in bind_to" This is a reland of commit fdb5de2c741658e94944f2ec1218530e98601c23 Original change's description: > [riscv] Fix Check failed in bind_to > > The trampoline should be emitted before the constant pool. > > Bug: 420232092 > > Change-Id: I3a909b122607e37aca9d8765f28810ec74d5dc0b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6578135 > Auto-Submit: Yahan Lu (LuYahan) <yahan@iscas.ac.cn> > Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> > Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> > Cr-Commit-Position: refs/heads/main@{#100480} Bug: 420232092 Change-Id: I1fac1ed8c349383ef4510abea338b3d695ed57ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6595668 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#100745} Refs: v8/v8@bbaae8e Co-authored-by: kxxt <rsworktech@outlook.com>

Original commit message: [riscv] Check trampoline before Constant pool in Release mode Change-Id: I9645cded9328dabb2c11c7859b998c838b95f97b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653368 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#100935} Refs: v8/v8@394a805

nodejs-github-bot · 2025-12-08T15:27:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70431/

nodejs-github-bot · 2025-12-08T15:27:46Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6912/

nodejs-github-bot · 2025-12-08T15:28:53Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6912/

nodejs-github-bot · 2025-12-08T15:30:48Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6912/

sxa

Noting that #60995 has been submitted to mark another test as flaky so this shouldn't cause a problem going forward 👍🏻

nodejs-github-bot · 2025-12-08T23:48:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70443/

kxxt · 2025-12-10T07:33:19Z

The CI is green now.

Original commit message: Reland "[riscv] Fix Check failed in bind_to" This is a reland of commit fdb5de2c741658e94944f2ec1218530e98601c23 Original change's description: > [riscv] Fix Check failed in bind_to > > The trampoline should be emitted before the constant pool. > > Bug: 420232092 > > Change-Id: I3a909b122607e37aca9d8765f28810ec74d5dc0b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6578135 > Auto-Submit: Yahan Lu (LuYahan) <yahan@iscas.ac.cn> > Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> > Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> > Cr-Commit-Position: refs/heads/main@{#100480} Bug: 420232092 Change-Id: I1fac1ed8c349383ef4510abea338b3d695ed57ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6595668 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#100745} Refs: v8/v8@bbaae8e Co-authored-by: kxxt <rsworktech@outlook.com> PR-URL: #60962 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>

Original commit message: [riscv] Check trampoline before Constant pool in Release mode Change-Id: I9645cded9328dabb2c11c7859b998c838b95f97b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653368 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#100935} Refs: v8/v8@394a805 PR-URL: #60962 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>

richardlau · 2025-12-10T17:21:25Z

Landed in 2ac18ce...105fbdd

Original commit message: Reland "[riscv] Fix Check failed in bind_to" This is a reland of commit fdb5de2c741658e94944f2ec1218530e98601c23 Original change's description: > [riscv] Fix Check failed in bind_to > > The trampoline should be emitted before the constant pool. > > Bug: 420232092 > > Change-Id: I3a909b122607e37aca9d8765f28810ec74d5dc0b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6578135 > Auto-Submit: Yahan Lu (LuYahan) <yahan@iscas.ac.cn> > Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> > Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> > Cr-Commit-Position: refs/heads/main@{#100480} Bug: 420232092 Change-Id: I1fac1ed8c349383ef4510abea338b3d695ed57ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6595668 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#100745} Refs: v8/v8@bbaae8e Co-authored-by: kxxt <rsworktech@outlook.com> PR-URL: #60962 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>

Original commit message: [riscv] Check trampoline before Constant pool in Release mode Change-Id: I9645cded9328dabb2c11c7859b998c838b95f97b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653368 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#100935} Refs: v8/v8@394a805 PR-URL: #60962 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Dec 5, 2025

kxxt mentioned this pull request Dec 5, 2025

Tracking issue for problems on RISC-V Linux platform nodejs/build#4099

Open

10 tasks

richardlau linked an issue Dec 5, 2025 that may be closed by this pull request

[RISCV] Check failed: (trampoline_pos - fixup_pos) <= kMaxBranchOffset. #60895

Closed

richardlau approved these changes Dec 5, 2025

View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2025

richardlau mentioned this pull request Dec 5, 2025

deps: V8: increase RISC-V trampoline pool gap #60909

Closed

sxa approved these changes Dec 5, 2025

View reviewed changes

kxxt force-pushed the v24-bind-to-riscv branch from 60c872c to 98cbf7d Compare December 6, 2025 14:13

sxa added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2025

github-actions Bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Dec 8, 2025

luyahan and others added 2 commits December 8, 2025 21:15

kxxt force-pushed the v24-bind-to-riscv branch from 98cbf7d to 0a99a89 Compare December 8, 2025 13:16

kxxt requested review from richardlau and sxa December 8, 2025 13:16

richardlau approved these changes Dec 8, 2025

View reviewed changes

richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Dec 8, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2025

sxa mentioned this pull request Dec 8, 2025

test: mark stringbytes-external-max flaky on AIX #60995

Merged

sxa approved these changes Dec 8, 2025

View reviewed changes

richardlau closed this Dec 10, 2025

github-actions Bot mentioned this pull request Feb 3, 2026

2026-02-10, Version 24.13.1 'Krypton' (LTS) #61661

Merged

Uh oh!

Uh oh!

Conversation

kxxt commented Dec 5, 2025

Uh oh!

nodejs-github-bot commented Dec 5, 2025

Uh oh!

nodejs-github-bot commented Dec 5, 2025

Uh oh!

nodejs-github-bot commented Dec 5, 2025

Uh oh!

nodejs-github-bot commented Dec 5, 2025

Uh oh!

nodejs-github-bot commented Dec 5, 2025

Uh oh!

kxxt commented Dec 6, 2025

Uh oh!

nodejs-github-bot commented Dec 6, 2025

Uh oh!

kxxt commented Dec 6, 2025

Uh oh!

nodejs-github-bot commented Dec 6, 2025

Uh oh!

kxxt commented Dec 6, 2025

Uh oh!

kxxt commented Dec 6, 2025

Uh oh!

sxa commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

github-actions Bot commented Dec 8, 2025

Uh oh!

kxxt commented Dec 8, 2025

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

sxa left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Dec 8, 2025

Uh oh!

kxxt commented Dec 10, 2025

Uh oh!

richardlau commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sxa commented Dec 8, 2025 •

edited

Loading