tools: validate commit list as part of lint-release-commit#56291
Merged
Conversation
Collaborator
|
Review requested:
|
richardlau
reviewed
Dec 17, 2024
ruyadorno
reviewed
Dec 18, 2024
jasnell
approved these changes
Dec 28, 2024
Contributor
Author
|
@nodejs/releasers I'm planing on landing this later this week if I don't receive more feedback on it |
Collaborator
|
Landed in e1df1e0 |
Merged
This was referenced Mar 17, 2025
This was referenced Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating manually a release proposal, it can be easy to have the commit list in the CHANGELOG and the actual list of commits in the proposal no longer in sync.
It will also double check that none of the commits being released comes from a PR with the
dont-land-onvXX.x, in case the label was added after the commit was already backported.I'm also switching to using
make release-onlywhich contains the checks we were doing and more.You can test it locally while the v23.5.0 proposal is open: