💡 Tips: test_runner: support typescript module mocking by marco-ippolito · Pull Request #54878 · nodejs/node · GitHub

marco-ippolito · 2024-09-10T16:03:03Z

Ugh I named the branch with ò character and GitHub complains :(

nodejs-github-bot · 2024-09-10T16:03:08Z

Review requested:

@nodejs/loaders
@nodejs/test_runner
@nodejs/typescript

github-actions · 2024-09-10T16:19:22Z

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 400 Bad Request

https://github.com/nodejs/node/actions/runs/10796555755

nodejs-github-bot · 2024-09-10T16:41:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62282/

codecov · 2024-09-10T17:55:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (5de919b) to head (87c6d5e).
Report is 578 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54878      +/-   ##
==========================================
+ Coverage   87.89%   88.02%   +0.13%     
==========================================
  Files         651      652       +1     
  Lines      183364   183764     +400     
  Branches    35711    35865     +154     
==========================================
+ Hits       161167   161766     +599     
+ Misses      15466    15244     -222     
- Partials     6731     6754      +23

Files with missing lines	Coverage Δ
lib/internal/modules/esm/translators.js	`92.42% <ø> (+0.72%)`	⬆️
lib/internal/test_runner/mock/loader.js	`95.52% <100.00%> (ø)`
lib/internal/test_runner/mock/mock.js	`99.25% <100.00%> (+<0.01%)`	⬆️

... and 101 files with indirect coverage changes

marco-ippolito · 2024-09-11T09:52:56Z

not sure if its a semver minor or patch

cjihrig · 2024-09-11T12:19:20Z

I think this is semver patch. Plus these are all experimental features anyway.

nodejs-github-bot · 2024-09-11T13:38:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62319/

nodejs-github-bot · 2024-09-12T08:11:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62352/

atlowChemi · 2024-09-12T17:56:17Z

+
+test('logger', async () => {
+
+    const { logger: mockedModule} = await import('./module-logger.ts');


Suggested change

const { logger: mockedModule} = await import('./module-logger.ts');

const { logger: mockedModule } = await import('./module-logger.ts');

nodejs-github-bot · 2024-09-15T14:59:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62455/

cjihrig · 2024-09-15T20:21:11Z

It looks like there is a relevant failure in the CI.

marco-ippolito · 2024-09-16T08:41:46Z

I think its related to #54645 since it only happens on windows arm64 😭

cjihrig · 2024-09-18T16:55:53Z

Should we skip on that platform? For the purposes of module mocking I think that would be adequate.

marco-ippolito · 2024-09-19T11:32:08Z

Should we skip on that platform? For the purposes of module mocking I think that would be adequate.

sure, I added the skip on windows arm on the test

nodejs-github-bot · 2024-09-19T11:37:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62561/

nodejs-github-bot · 2024-09-19T13:36:53Z

Landed in bb40521

PR-URL: #54878 Fixes: #54428 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

PR-URL: nodejs#54878 Fixes: nodejs#54428 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 10, 2024

jasnell approved these changes Sep 10, 2024

View reviewed changes

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2024

github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 10, 2024

marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Sep 10, 2024

cjihrig approved these changes Sep 10, 2024

View reviewed changes

Comment thread lib/internal/test_runner/mock/loader.js

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2024

avivkeller added the strip-types Issues or PRs related to strip-types support label Sep 10, 2024

MoLow approved these changes Sep 10, 2024

View reviewed changes

ErickWendel approved these changes Sep 10, 2024

View reviewed changes

benjamingr approved these changes Sep 10, 2024

View reviewed changes

Qard approved these changes Sep 10, 2024

View reviewed changes

marco-ippolito added semver-minor PRs that contain new features and should be released in the next minor version. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Sep 11, 2024

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2024

atlowChemi reviewed Sep 12, 2024

View reviewed changes

test_runner: support typescript module mocking

87c6d5e

marco-ippolito force-pushed the fix/mock-moduòe branch from c2f4b08 to 87c6d5e Compare September 19, 2024 11:30

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024

ShogunPanda approved these changes Sep 19, 2024

View reviewed changes

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024

nodejs-github-bot merged commit bb40521 into nodejs:main Sep 19, 2024

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

marco-ippolito added the dont-land-on-v20.x label Nov 16, 2024


		test('logger', async () => {

		const { logger: mockedModule} = await import('./module-logger.ts');

	const { logger: mockedModule} = await import('./module-logger.ts');
	const { logger: mockedModule } = await import('./module-logger.ts');

Uh oh!

Uh oh!

Hidden character warning

Conversation

marco-ippolito commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 10, 2024

Uh oh!

github-actions Bot commented Sep 10, 2024

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 10, 2024

Uh oh!

codecov Bot commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

marco-ippolito commented Sep 11, 2024

Uh oh!

cjihrig commented Sep 11, 2024

Uh oh!

nodejs-github-bot commented Sep 11, 2024

Uh oh!

nodejs-github-bot commented Sep 12, 2024

Uh oh!

atlowChemi Sep 12, 2024

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 15, 2024

Uh oh!

cjihrig commented Sep 15, 2024

Uh oh!

marco-ippolito commented Sep 16, 2024

Uh oh!

cjihrig commented Sep 18, 2024

Uh oh!

marco-ippolito commented Sep 19, 2024

Uh oh!

nodejs-github-bot commented Sep 19, 2024

Uh oh!

nodejs-github-bot commented Sep 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

marco-ippolito commented Sep 10, 2024 •

edited

Loading

codecov Bot commented Sep 10, 2024 •

edited

Loading