Skip to content

test_runner: report file in test runner events#46030

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
MoLow:test-runner-report-files
Jan 2, 2023
Merged

test_runner: report file in test runner events#46030
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
MoLow:test-runner-report-files

Conversation

@MoLow

@MoLow MoLow commented Dec 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

this adds the test file related to the current event.
this will be specifically useful if we implement #45833 (comment) since that will then be the only way to access this information

@nodejs-github-bot

nodejs-github-bot commented Dec 31, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 31, 2022
@MoLow MoLow added the test_runner Issues and PRs related to the test runner subsystem. label Dec 31, 2022
@MoLow

MoLow commented Jan 2, 2023

Copy link
Copy Markdown
Member Author

CC @nodejs/test_runner

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48804/

@nodejs-github-bot

nodejs-github-bot commented Jan 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48805/

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 2, 2023
cjihrig
cjihrig reviewed Jan 2, 2023
View reviewed changes
Comment thread test/fixtures/test-runner/custom_reporters/custom.js Outdated
Comment thread doc/api/test.md Outdated
@MoLow MoLow removed commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 2, 2023
@MoLow MoLow requested a review from cjihrig January 2, 2023 18:15
@MoLow MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 2, 2023
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 2, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48811/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 2, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 2, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9eb363a into nodejs:main Jan 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 2, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9eb363a

@MoLow MoLow deleted the test-runner-report-files branch January 2, 2023 21:51
@MoLow

MoLow commented Jan 18, 2023

Copy link
Copy Markdown
Member Author

I won't be in front a computer for another week or so, will handle then

@juanarbol

juanarbol commented Jan 24, 2023

Copy link
Copy Markdown
Member

After resolving multiple merge conflicts, this breaks some tests in the v18.x release line.

MoLow added a commit to MoLow/node that referenced this pull request Jan 26, 2023
@MoLow
test_runner: report file in test runner events
a52fd1a 
PR-URL: nodejs#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jan 26, 2023
@MoLow
test_runner: report file in test runner events
b0a88f6 
PR-URL: nodejs#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jan 26, 2023
@MoLow
test_runner: report file in test runner events
51ca23e 
PR-URL: nodejs#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MoLow MoLow mentioned this pull request Jan 26, 2023
Closed
MoLow added a commit to MoLow/node that referenced this pull request Jan 26, 2023
@MoLow
test_runner: report file in test runner events
01e3ac4 
PR-URL: nodejs#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MoLow

MoLow commented Jan 26, 2023

Copy link
Copy Markdown
Member Author

This commit didn't land cleanly on v19.x-staging, can you create a manual backport? I believe it didn't work because it depends on #45712, which is blocked.

@RafaelGSS Why is #45712 blocked?

MoLow added a commit to MoLow/node that referenced this pull request Jan 26, 2023
@MoLow
test_runner: report file in test runner events
cfa5c37 
PR-URL: nodejs#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MoLow MoLow mentioned this pull request Jan 26, 2023
Closed
@RafaelGSS

RafaelGSS commented Jan 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This commit didn't land cleanly on v19.x-staging, can you create a manual backport? I believe it didn't work because it depends on #45712, which is blocked.

@RafaelGSS Why is #45712 blocked?

Because of #45712 (comment).

if that was already addressed/released. Feel free to remove the block labels.

MoLow added a commit to MoLow/node that referenced this pull request Jan 26, 2023
@MoLow
test_runner: report file in test runner events
d90d1b3 
PR-URL: nodejs#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 31, 2023
@MoLow @ruyadorno
test_runner: report file in test runner events
a49e17e 
Backport-PR-URL: #46361
PR-URL: #46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 6, 2023
@MoLow
feat: report file in test runner events
bf09974 
PR-URL: nodejs/node#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
(cherry picked from commit 9eb363a3e00dbba572756c7ed314273f17ea8e2e)
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
@MoLow
feat: report file in test runner events
a47cacd 
PR-URL: nodejs/node#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
(cherry picked from commit 9eb363a3e00dbba572756c7ed314273f17ea8e2e)
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
@MoLow
feat: report file in test runner events
f501f9c 
PR-URL: nodejs/node#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
(cherry picked from commit 9eb363a3e00dbba572756c7ed314273f17ea8e2e)
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
@MoLow
feat: report file in test runner events
29c73b4 
PR-URL: nodejs/node#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
(cherry picked from commit 9eb363a3e00dbba572756c7ed314273f17ea8e2e)
MoLow added a commit to nodejs/node-core-test that referenced this pull request Feb 8, 2023
@MoLow
feat: report file in test runner events
10d6603 
PR-URL: nodejs/node#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
(cherry picked from commit 9eb363a3e00dbba572756c7ed314273f17ea8e2e)
MoLow added a commit to MoLow/node that referenced this pull request Feb 25, 2023
@MoLow
test_runner: report file in test runner events
b628161 
PR-URL: nodejs#46030
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@MoLow @juanarbol
test_runner: report file in test runner events
b4fca7c 
PR-URL: #46030
Backport-PR-URL: #46839
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@MoLow @juanarbol
test_runner: report file in test runner events
79f4b42 
PR-URL: #46030
Backport-PR-URL: #46839
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MoLow @nodejs-github-bot @RafaelGSS @juanarbol @benjamingr @cjihrig @aduh95