esm: unflag --experimental-exports#29867
Closed
guybedford wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
the
c++
14 tasks
guybedford
added
the
esm
Contributor
Author
|
//cc @nodejs/modules-active-members |
Member
|
Added the WIP label based on the PR description (although feel free to swap it out for the blocked label if that's more appropriate). |
guybedford
force-pushed
the
unflag-exports
branch
from
1131512 to
14dfa97
Compare
Contributor
Author
|
We got resolution in today's meeting to merge this, with the behaviour still flagged by We just need core collaborator approvals to land further. |
hybrist
approved these changes
Oct 9, 2019
hybrist
left a comment
hybrist
left a comment
Contributor
There was a problem hiding this comment.
LGTM, as discussed in the WG meeting.
Collaborator
guybedford
added
the
author ready
Contributor
Author
|
Can I get a further review here from someone? Would be great to land soon to prepare for #29866. |
cjihrig
approved these changes
Oct 10, 2019
This comment has been minimized.
This comment has been minimized.
guybedford
force-pushed
the
unflag-exports
branch
from
14dfa97 to
add19fc
Compare
Collaborator
Contributor
Author
|
Thanks @Trott just running a final CI with the latest rebase. |
Trott
reviewed
Oct 10, 2019
guybedford
force-pushed
the
unflag-exports
branch
from
add19fc to
8ff42aa
Compare
Collaborator
Member
|
Landed in b798f64 |
Trott
pushed a commit
that referenced
this pull request
Oct 10, 2019
PR-URL: #29867 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
PR-URL: #29867 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
added
the
semver-minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the experimental
--experimental-exportsflag to make the support on by default.This PR should not land until we have:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes