v9.4.0 proposal#18069
Merged
Merged
Conversation
The function was never documented and now throws a TypeError if used. PR-URL: #13735 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
The mustCall is actually only necessary in case it is used as callback. Otherwise it works as a must call on its own. PR-URL: #17616 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
PR-URL: #17610 Refs: #17054 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Document and test the existing support for generic Duplex streams in the TLS module. PR-URL: #17599 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fix a nullptr dereference on abrupt termination when async call stack recording is enabled. Bug discovered while trying to write a regression test for the bug fix in commit df79b7d ("src: fix missing handlescope bug in inspector".) PR-URL: #17577 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
PR-URL: #17535 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #17117 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #17117 Reviewed-By: James M Snell <jasnell@gmail.com>
This is unnecessary since we only run `AppendExceptionLine()` once per exception at this point anyway. PR-URL: #17394 Reviewed-By: James M Snell <jasnell@gmail.com>
Keep track of C++ `TryCatch` state to avoid aborting when an exception is thrown inside one, and re-throw in JS to make sure the exception is being picked up a second time by a second uncaught exception handler, if necessary. Add a bit of a hack to `AppendExceptionLine` to avoid overriding the line responsible for re-throwing the exception. PR-URL: #17394 Fixes: #13258 Reviewed-By: James M Snell <jasnell@gmail.com>
Currently the following warning is show when building:
../src/node_contextify.cc:642:10:
warning: unused variable 'display_errors' [-Wunused-variable]
bool display_errors = maybe_display_errors.ToChecked();
This commit removes the unused variable which became unused in commit
aeddc36 ("src: remove tracking for
exception arrow data").
PR-URL: #17491
Refs: #17394
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
`tls.Socket` does not exist, and the deprecation message should refer to `tls.TLSSocket` (like the documentation for the deprecation message already does). PR-URL: #17561 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
- Remove pointless pointers - Make `WriteHost` take a const argument so that it’s functionality is clear from the signature - Make `FindLongestZeroSequence` templated to accommodate the constness in `WriteHost` and because using `uint16_t` is an articifial, unnecessary restriction - Remove string copying when no copies are needed - Make `PercentDecode` just return its return value - Make `ParseHost` (string-only version) take its constant argument as a constant reference PR-URL: #17470 Reviewed-By: Timothy Gu <timothygu99@gmail.com>
This helps because `static` doesn’t work for C++ classes, but refactoring `url_host` into a proper C++ class seems the most reasonable soluation for the memory leak fixed by the next commit. PR-URL: #17470 Reviewed-By: Timothy Gu <timothygu99@gmail.com>
- Gives `URLHost` a proper destructor that clears memory depending on the type of the host (This fixes a memory leak) - Hide the host type enums and class layout as implementation details - Make the `Parse` methods members of `URLHost` - Turn `WriteHost` into a `ToString()` method on the `URLHost` class - Verify that at the beginning of a parse attempt, the type is set to “failed” - Remove a lot of `goto`s from the source code 🐢🚀 PR-URL: #17470 Fixes: #17448 Reviewed-By: Timothy Gu <timothygu99@gmail.com>
`last_piece` pointed to the end of the 8×16 bit array, so `piece_pointer == last_piece` already means that the pointer is not writable any longer. Previously, this still worked most of the time but could result in an out-of-bounds-write. Also, rename `last_piece` to `buffer_end` to avoid this pitfall. PR-URL: #17470 Reviewed-By: Timothy Gu <timothygu99@gmail.com>
- Call randomBytes with a non-function callback - Call randomFill with a non-function callback PR-URL: #17555 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #17595 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Currently the documentation states that promisify() will result in undefined behavior if bad arguments are passed. This is not necessarily the case, since the behavior is well defined, but just not useful. PR-URL: #17593 Fixes: #17569 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: #16778 PR-URL: #17594 Fixes: #16778 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Add an unhandled rejection function in addons-napi/test_promise/test.js. Also, add a rejection handler to catch the unhandled rejection after introducing the guard and test the reason code. PR-URL: #17275 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
- Handle exceptions when getting `process.emitWarning` or when calling it properly - Add `Maybe<bool>` to the return type, like the V8 API uses it to indicate failure conditions - Update call sites to account for that and clean up/return to JS when encountering an error - Add an internal `ProcessEmitDeprecationWarning()` sibling for use in #17417, with common code extracted to a helper function - Allow the warning to contain non-Latin-1 characters. Since the message will usually be a template string containing data passed from the user, this is the right thing to do. - Add tests for the failure modes (except string creation failures) and UTF-8 warning messages. PR-URL: #17420 Refs: #17417 Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
According to the linked document: "The length of the randomly-generated portion of the salt shall be at least 128 bits." [NIST SP 800-132] PR-URL: #17524 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
test-child-process-pass-fd needs to launch many processes simultaneously. On Fedora 24, this can result in EAGAIN "Resource temporarily unavailable" errors. When this occurs, simply try to launch a worker again. PR-URL: #17598 Fixes: #17589 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16042 Refs: #1826 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #17395 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
When the TLS stream is destroyed for whatever reason, we should unset all callbacks on the underlying transport stream. PR-URL: #17478 Fixes: #17475 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16975 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
PR-URL: #16975 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
The root .gitignore contains "node", which causes all of deps/v8/tools/node to be ignored. That is somewhat inconvenient when updating V8. PR-URL: #18010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #18007 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jon Moss <me@jonathanmoss.me>
PR-URL: #17971 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Add an aliased buffer for session and stream statistics, add a few more metrics PR-URL: #18020 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
The `buffer` argument must be either Buffer or Uint8Array, string values are not supported. PR-URL: #18022 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
force-pushed
the
v9.4.0-proposal
branch
from
09e837d to
9d4f960
Compare
Contributor
Author
|
Had to drop #16591 as it was breaking odroid One last ci: https://ci.nodejs.org/job/node-test-pull-request/12478/ Citgm looks good!!! |
MylesBorins
force-pushed
the
v9.4.0-proposal
branch
from
9d4f960 to
7142407
Compare
Original commit message:
[inspector] added Runtime.globalLexicalScopeNames method
The method returns names for all available top-level scope variables
in giving context.
R=dgozman@chromium.org,jgruber@chromium.org
Bug: chromium:681333
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2d0b600e1afbfef9087f53ea9c26abe1e112047c
Reviewed-on: https://chromium-review.googlesource.com/719409
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48618}
Refs: v8/v8@50f7455
PR-URL: #16591
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
LGTM |
Notable change:
* async_hooks:
- deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither
API were documented. (Andreas Madsen)
#16972
* deps:
- update nghttp2 to 1.29.0 (James M Snell)
#17908
- upgrade npm to 5.6.0 (Kat Marchán)
#17535
- cherry-pick 50f7455 from upstream V8 (Michaël Zasso)
#16591
* events:
- remove reaches into _events internals (Anatoli Papirovski)
#17440
* http:
- add rawPacket in err of `clientError` event (XadillaX)
#17672
* http2:
- implement maxSessionMemory (James M Snell)
#17967
- add initial support for originSet (James M Snell)
#17935
- add altsvc support (James M Snell)
#17917
- perf_hooks integration (James M Snell)
#17906
- Refactoring and cleanup of Http2Session and Http2Stream destroy
(James M Snell) #17406
* net:
- remove Socket.prototype.write (Anna Henningsen)
#17644
- remove Socket.prototype.listen (Ruben Bridgewater)
#13735
* repl:
- show lexically scoped vars in tab completion (Michaël Zasso)
#16591
* stream:
- rm {writeable/readable}State.length (Calvin Metcalf)
#12857
- add flow and buffer properties to streams (Calvin Metcalf)
#12855
* util:
- allow wildcards in NODE_DEBUG variable (Tyler)
#17609
* zlib:
- add ArrayBuffer support (Jem Bezooyen)
#16042
* Addedew collaborator**
- [starkwang](https://github.com/starkwang) Weijia Wang
* Addedew TSC member**
- [danbev](https://github.com/danbev) Daniel Bevenius
PR-URL: #18069
MylesBorins
force-pushed
the
v9.4.0-proposal
branch
from
7142407 to
7aefa40
Compare
Contributor
Author
|
Based on that CI run and https://ci.nodejs.org/job/node-test-commit-arm/13013/ I think it is safe to say that #16591 is unrelated to the failures we are seeing on odroid. I'm going to sign off on that being an infra flake and open an issue on build. one more ci |
Contributor
|
Is it also possible to add V8 6.3 into this release? |
Contributor
Author
|
CI is green aside from odroid which is documented to have issues nodejs/build#884 Going to move forward with this release @bricss if we wanted to land 6.3 we would need to ensure ABI compatibility and I'm not sure anyone has time to do that work right now. Whatever the case we wouldn't be able to get it in for today's release |
Member
I really wouldn’t call that out as a notable change – nothing about the method’s usage changed. |
MylesBorins
added a commit
that referenced
this pull request
Jan 10, 2018
Notable change:
* async_hooks:
- deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither
API were documented. (Andreas Madsen)
#16972
* deps:
- update nghttp2 to 1.29.0 (James M Snell)
#17908
- upgrade npm to 5.6.0 (Kat Marchán)
#17535
- cherry-pick 50f7455 from upstream V8 (Michaël Zasso)
#16591
* events:
- remove reaches into _events internals (Anatoli Papirovski)
#17440
* http:
- add rawPacket in err of `clientError` event (XadillaX)
#17672
* http2:
- implement maxSessionMemory (James M Snell)
#17967
- add initial support for originSet (James M Snell)
#17935
- add altsvc support (James M Snell)
#17917
- perf_hooks integration (James M Snell)
#17906
- Refactoring and cleanup of Http2Session and Http2Stream destroy
(James M Snell) #17406
* net:
- remove Socket.prototype.write (Anna Henningsen)
#17644
- remove Socket.prototype.listen (Ruben Bridgewater)
#13735
* repl:
- show lexically scoped vars in tab completion (Michaël Zasso)
#16591
* stream:
- rm {writeable/readable}State.length (Calvin Metcalf)
#12857
- add flow and buffer properties to streams (Calvin Metcalf)
#12855
* util:
- allow wildcards in NODE_DEBUG variable (Tyler)
#17609
* zlib:
- add ArrayBuffer support (Jem Bezooyen)
#16042
* Addedew collaborator**
- [starkwang](https://github.com/starkwang) Weijia Wang
* Addedew TSC member**
- [danbev](https://github.com/danbev) Daniel Bevenius
PR-URL: #18069
Contributor
Author
|
@addaleax just missed that by a moment and the release is out. Want to send a PR to remove from changelog? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2018-01-10, Version 9.4.0 (Current), @MylesBorins
Notable Changes
clientErrorevent (XadillaX) #17672Commits
ec443c3430] - assert: fix .throws operator (Ruben Bridgewater) #175750843ed6ae7] - async_hooks: use CHECK instead of throwing error (Jon Moss) #1783223f4433f89] - (SEMVER-MINOR) async_hooks: deprecate undocumented API (Andreas Madsen) #1697263c23a1ff2] - benchmark: fix timeout in write-stream-throughput (Anatoli Papirovski) #1795814eb97ebf7] - benchmark: make temp file path configurable (Rich Trott) #1781127227cf4c7] - benchmark: refactor console benchmark (Ruben Bridgewater) #177070aa403b649] - buffer: optimize readDouble and readFloat methods (Ben Noordhuis) #17775d93b4765a5] - build: document targets in the Makefile (Joyee Cheung) #16975224033db56] - build: put .PHONY directly before its target (Oky Antoro) #179642d857ed7c8] - build: remove duplicate async-hooks and known_issues test runs (Rich Trott) #17912d066db7014] - cluster: support windowsHide option for workers (Todd Wong) #1741228283efd89] - console: order functions and remove \n\n (Ruben Bridgewater) #1770741e2bb185d] - console: make variables and checks stricter (Ruben Bridgewater) #177070573c0fb23] - console: make error handling engine agnostic (Ruben Bridgewater) #177071b8d3ec5e7] - crypto: add ocsp_request ClientHelloParser::Reset (Daniel Bevenius) #17753d387c178b2] - crypto: warn on invalid authentication tag length (Tobias Nießen) #175667153434fae] - crypto: reuse variable instead of reevaluation (Tobias Nießen) #177357d03567287] - crypto: remove unused header in clienthello.h (Daniel Bevenius) #17752dfb9b5e83a] - crypto: move node_crypto_clienthello-inl.h to cc (Daniel Bevenius) #176065df8c76ea9] - deps: update nghttp2 to 1.29.0 (James M Snell) #179088f3b2d7e8a] - deps: V8: cherry-pick ac0fe8ec from upstream (Ali Ijaz Sheikh) #17695ffe1ad6c12] - deps: upgrade npm to 5.6.0 (Kat Marchán) #17535ffc2659964] - doc: fix incorrect argument type in fs.readSync (Mykola Bilochub) #18022ef317014e2] - doc: compact eslint directives in common/README (Vse Mozhet Byt) #179713623cf7ec7] - doc: add guide on maintaining build files (Joyee Cheung) #16975b593d946e4] - doc: re-alphabetise sections in common/README.md (Vse Mozhet Byt) #179713bcdb3b996] - doc: fix code nits in common/README (Vse Mozhet Byt) #179710ad783afaf] - doc: fix link for https api change (Myles Borins) #176301181ff7ecc] - doc: correct spelling (sreepurnajasti) #1791143ac36c6de] - doc: grammar fixes in http2.md (Rich Trott) #1797246f39b590b] - doc: add docs for common/http2.js utility (James M Snell) #1794283c725dc73] - doc: updates examples to use NULL (Michael Dawson) #1800872ed11ac78] - doc: move matthewloring to emeriti (Rich Trott) #179986efef47c2a] - doc: move joshgav to TSC emeriti list (Rich Trott) #17953294c5f4ef0] - doc: improve security section of README.md (Rich Trott) #17929445c911ba4] - doc: edit for concision (Rich Trott) #178913fd65815f8] - doc: remove x86 from os.arch() options (Gibson Fahnestock) #1789914499f8185] - doc: improve PR-review paragraph in CONTRIBUTING.md (Rich Trott) #1793154cf75ddb5] - doc: fix typos in CONTRIBUTING.md (Rich Trott) #1793016fbd5718a] - doc: remove non-style information from style guide (Rich Trott) #17866a702fcbd4b] - doc: copy-edit COLLABORATOR_GUIDE.md (Rich Trott) #17922240121ec42] - doc: improve alt text (Rich Trott) #17922312ad06cfe] - doc: fix spelling of contributors (Rich Trott) #179222f7030de31] - doc: add references to PR communication articles (Salame William) #17902d2b1601bd3] - doc: replace wrong U+00A0 by common spaces (Vse Mozhet Byt) #17940658bdb34aa] - doc: remove duplicate words in API docs (Tobias Nießen) #17937181b8970b1] - doc: fix duplicate words & spellings in docs (sreepurnajasti) #179234850c87348] - doc: doc imitating the old behavior of http.Server.keepAliveTimeout (Tyson Andre) #17660b15f029b04] - doc: fs doc improvements (James M Snell) #178319fc9bb1c09] - doc: fix typo (Tobias Nießen) #179002c9dab313e] - doc: use my legal name in README (Timothy Gu) #17894cb127de634] - doc: improve module.builtinModules text (Rich Trott) #178651be0086ec8] - doc: use dashes instead of asterisks (Ruben Bridgewater) #1772226fbb0f78a] - doc: use consistent new lines (Ruben Bridgewater) #17722a63d3c514d] - doc: update formatting to fit our 80 chars rule (Ruben Bridgewater) #1772259711ae42a] - doc: update AUTHORS list (Ruben Bridgewater) #178052d11f6b669] - doc: add starkwang to collaborators (Weijia Wang) #17847fe1f67f184] - doc: mark DEP0002 as end of life (Jon Moss) #17815d4666d0d7a] - doc: require CI status indicator in PRs (Nikolai Vavilov) #17151541d189db9] - doc: use american spelling as per style guide (sreepurnajasti) #1781869945596e4] - doc: removed extra explanation in api/buffer.md (Waleed Ashraf) #17796c328e580d1] - doc: improve module.builtinModules documentation (Thomas Watson) #177121d935a0b2d] - doc: instructions on how to make membership public (Michael Dawson) #17688b6d2090c8b] - doc: improve fs api descriptions (Evan Lucas) #17679b1a8ac7774] - doc: remove old console note (Ruben Bridgewater) #17707c982494433] - doc: remove duplicate the from onboarding.md (sreepurnajasti) #17733206c4f85c5] - doc: fix typo in README.md (Weijia Wang) #17729dbc554a225] - doc: fix typo in child_process.md (Rich Trott) #17727dd9d07caa7] - doc: remove unused link definition (Jon Moss) #17741dcfe840a1e] - doc: edit CONTRIBUTING.md preamble (Rich Trott) #17700ed9f2fef70] - doc: improve release guide (Evan Lucas) #17677861f6adb70] - doc: some fs doc improvements (James M Snell) #17692ecbc70fe5d] - doc: not all example code can be run without 1:1 (Jeremiah Senkpiel) #1770268722fd16e] - doc: adjust TTY wording & add inter-doc links (Jeremiah Senkpiel) #17702d19343147b] - doc: fix fs.existsSync description (Jeremiah Senkpiel) #17702444362e048] - doc: improve documentation.md (Jeremiah Senkpiel) #17702d1af106b76] - doc: add countdown module to writing tests guide (Bamieh) #17201e059bc5503] - doc: change "Node.js style cb" to "error-first cb" (Ram Goli) #17638712848bc7d] - doc: change eventName type annotations (April Webster) #17666c24b4dd898] - doc: remove extra whitespace in module docs (Thomas Watson) #17711af1b340e39] - doc: add C++ style comments to the style guide (Matheus Marchini) #176175999a11526] - doc: include Daniel Bevenius as a TSC member (Rich Trott) #17652977fb13bd5] - doc: import() is supported now (Gus Caplan) #17395ed4d013f48] - doc: correct pbkdf2 salt length recommendation (Will Clark) #17524d70e6dc850] - doc: note that randomBytes throws when passed null (Tobias Nießen) #17594da448216cc] - doc: clearify promisify behavior for bad arguments (Ram Goli) #1759326025dec62] - doc: replace ArrayBufferView in crypto (Tobias Nießen) #175951a84005150] - doc,test: mention Duplex support for TLS (Anna Henningsen) #175997008719fb6] - (SEMVER-MINOR) events: remove reaches into _events internals (Anatoli Papirovski) #17440f1485565ef] - fs: guarantee order of callbacks in ws.close (Matteo Collina) #1800266c1a038a1] - gitignore: ignore *.VC.db files (Tobias Nießen) #178988e1011f93b] - http: remove duplicate export (Evan Lucas) #17982f82439b6a0] - (SEMVER-MINOR) http: add rawPacket in err ofclientErrorevent (XadillaX) #176729306de280f] - http: remove adapter frame from onParserExecute (Ben Noordhuis) #176931ad7df6acc] - http2: use aliased buffer for perf stats, add stats (James M Snell) #180206a67dfd927] - http2: verify flood error and unsolicited frames (James M Snell) #179696839283403] - http2: verify that a dependency cycle may exist (James M Snell) #17968865da60e75] - http2: implement maxSessionMemory (James M Snell) #17967f17a5b92dc] - http2: properly handle already closed stream error (James M Snell) #1794279d3198b7f] - http2: add aligned padding strategy (James M Snell) #179382b6a5d90bd] - http2: add initial support for originSet (James M Snell) #179359ad7a9a333] - http2: add altsvc support (James M Snell) #17917e7a727e9ba] - http2: strictly limit number on concurrent streams (James M Snell) #1676606aaaa8ad7] - http2: perf_hooks integration (James M Snell) #17906a003ded7fb] - http2: remove duplicate words in comments (Tobias Nießen) #179391b7ce1ea02] - http2: implement ref() and unref() on client sessions (Kelvin Jin) #17620b8deb7522f] - http2: keep session objects alive during Http2Scope (Anna Henningsen) #17863e3c567f05b] - http2: fix compiling with--debug-http2(Anna Henningsen) #178633a6b2ad19a] - http2: convert Http2Settings to an AsyncWrap (James M Snell) #17763bfc7e014cc] - http2: refactor outgoing write mechanism (Anna Henningsen) #177189592691d56] - http2: remove redundant write indirection (Anna Henningsen) #177185abb60933e] - http2: cleanup Http2Stream/Http2Session destroy (James M Snell) #17406f699a74e66] - http2: be sure to destroy the Http2Stream (James M Snell) #1740630e75e601b] - http2: only schedule write when necessary (Anna Henningsen) #17183d06ad0d4f0] - http2: don't call into JS from GC (Anna Henningsen) #17183f18d826660] - http2: simplify onSelectPadding (Anna Henningsen) #177178d4fca3fb5] - inspector: make Coverity happy (Eugene Ostroukhov) #17656b817a8a6b2] - lib: enable dot-notation eslint rule (Anatoli Papirovski) #180072d61b9eb9f] - lib, src: use process.config instead of regex (Jon Moss) #178143b2d8cba23] - module: print better message on esm import error (Michaël Zasso) #1778679a283307a] - n-api: fix memory leak in napi_async_destroy() (alnyan) #1771474a5bbaff4] - net: remove ADDRCONFIG DNS hint on Windows (Bartosz Sosnowski) #17662c3810e27bd] - net: remove Socket.prototype.write (Anna Henningsen) #17644e58a5ca854] - net: remove Socket.prototype.listen (Ruben Bridgewater) #137350e116a01c8] - perf_hooks: fix scheduling regression (Anatoli Papirovski) #18051a329cf62ab] - perf_hooks: refactor internals (James M Snell) #17822bf0a7b6e13] - process: fix coverage generation (Evan Lucas) #17651b1bc768a57] - readline: refactor filter() callback (Rich Trott) #178582cc50530d2] - repl: fix coloring ofprocess.versions(Ben Noordhuis) #17861bb9219bd19] - src: update make for new code coverage locations (Michael Dawson) #17987aa7519095c] - src: remove duplicate words in comments (Tobias Nießen) #17939f9c84c557f] - src: silence http2 -Wunused-result warnings (cjihrig) #179547e680807f8] - src: add optional keep-alive object to SetImmediate (Anna Henningsen) #1718398dc554a2a] - src: inline HostentToAddresses() (Ben Noordhuis) #1786087b336a2e5] - src: remove unused GetHostByNameWrap (Ben Noordhuis) #178602aa75a1f0b] - src: remove redundantJSStream::DoAfterWrite(Anna Henningsen) #1771399c62cc454] - src: remove unused async hooks methods (Anna Henningsen) #17757d6c588586a] - src: remove nonexistent method from header file (Anna Henningsen) #17748a93ed5c282] - src: replace SetAccessor w/ SetAccessorProperty (Jure Triglav) #17665d84d9be6ef] - src: renameOn*->Emit*for stream callbacks (Anna Henningsen) #177016f520e3f69] - src: remove unused strings from env.h (Anna Henningsen) #176436634dc4d0c] - src: fix -Wundefined-inline warnings (Ben Noordhuis) #176490c6d9ae72e] - src: fix compile warnings introduced in 73ad3f9 (Ben Noordhuis) #17649008336c920] - src: minor refactoring to StreamBase writes (Anna Henningsen) #175647ed9e5de39] - src: removeStreamResourc::Cast()(Anna Henningsen) #17564d879b63077] - src: make FSEventWrap/StatWatcher::Start more robust (Timothy Gu) #174326ba00b8d48] - src: refactor and hardenProcessEmitWarning()(Anna Henningsen) #17420316da5e667] - src: use correct OOB check for IPv6 parsing (Anna Henningsen) #17470ca3c2551b6] - src: make url host a proper C++ class (Anna Henningsen) #174709f1fe63c39] - src: move url internals into anonymous namespace (Anna Henningsen) #1747075f99b7c16] - src: minor cleanups to node_url.cc (Anna Henningsen) #174706bd0aff092] - src: remove unused variable in node_contextify (Daniel Bevenius) #17491df6acf9a84] - src: remove tracking for exception arrow data (Anna Henningsen) #17394e63e4a1fac] - src: remove async_hooks destroy timer handle (Anna Henningsen) #17117e1f0846a2b] - src: introduce internal C++ SetImmediate() mechanism (Anna Henningsen) #171177d1d7390eb] - src: fix inspector nullptr deref on abrupt exit (Ben Noordhuis) #17577c5c4a534d1] - (SEMVER-MINOR) stream: rm {writeable/readable}State.length (Calvin Metcalf) #128574b0c8759d3] - (SEMVER-MINOR) stream: add flow and buffer properties to streams (Calvin Metcalf) #12855757e685803] - stream: removeundefinedcheck (Anna Henningsen) #17644b313e81783] - test: fix flaky test-http-pipeline-flood (Anatoli Papirovski) #1795551eab4b005] - test: rename regression tests (Tobias Nießen) #179488806e54c24] - test: fix flaky test-http-highwatermark (Anatoli Papirovski) #179493399e8ac5a] - test: fix flaky test-pipe-unref (Anatoli Papirovski) #1795079980582b4] - test: fix flaky http-writable-true-after-close (Anatoli Papirovski) #17952591dd4e398] - test: fix crypto test case to use correct encoding (Tobias Nießen) #17956f87a1a6ca8] - test: simplify test-buffer-slice.js (Weijia Wang) #179623cc9882e8c] - test: fix flaky test-resolve-async (Anatoli Papirovski) #179573927c6f64e] - test: improve readability of some crypto tests (Tobias Nießen) #179042f4da8b801] - test: use countdown in test file (sreepurnajasti) #17874ef533c99ba] - test: add hasCrypto when using binding('crypto') (Daniel Bevenius) #17867421eb750b2] - test: improve to use template string (sreepurnajasti) #17895275970973e] - test: replace map() with forEach() where appropriate (Rich Trott) #17858f25bab5606] - test: fix flaky test-benchmark-fs (Rich Trott) #17885411e7724d4] - test: make test-tls-invoke-queued use public API (Anna Henningsen) #178641dd859d413] - test: refactor test-tls-securepair-fiftharg (Anna Henningsen) #178368b666d61c7] - test: reduce scope of variable in common module (Rich Trott) #178309110654965] - test: remove undefined function (Rich Trott) #17845ca35d08291] - test: remove ambiguous error messages from test_error (Nicholas Drane) #17812ee4cbac52b] - test: fix unreliable async-hooks/test-signalwrap (Rich Trott) #17827fea5d08d65] - test: fix flaky test-benchmark-fs (Rich Trott) #17853ded097a2bb] - test: use common module API in test-child-process-exec-stdout-stderr-data-string (sreepurnajasti) #1775106862f0c32] - test: do not open fixture files for writing (Rich Trott) #17810e9ace7e4dd] - test: do not open fixture files for writing (Rich Trott) #17808f79d2efedb] - test: use valid authentication tag length (Tobias Nießen) #17566112b655107] - test: improve flaky test-listen-fd-ebadf.js (Rich Trott) #17797dce7d7fc64] - test: refactor test-repl-definecommand (Rich Trott) #1779560ae55680c] - test: refactor test-net-connect-buffer (Anna Henningsen) #17710c9539678ca] - test: increase diffie-hellman test coverage (Leko) #177286d15185235] - test: increase pbkdf2 test coverage (Leko) #17730dd14004eed] - test: fix typo in test-inspector-cluster-port-clash.js (Rich Trott) #177825a9694eb60] - test: change callback function to arrow function (rt33) #17734305dd5671c] - test: add test for postmortem metadata validation (cjihrig) #17685d9190c17ed] - test: Use countdown in test file (sreepurnajasti) #1764646f8a9eddc] - test: update test-http-content-length to use countdown (Bamieh) #17201373d5df3b7] - test: coverage for emitExperimentalWarning (Mithun Sasidharan) #17635bc45354cce] - test: change callback function to arrow function (routerman) #17697d48a1b99ee] - test: change callback function to arrow function (you12724) #17698a9d83ce9e0] - test: change callback function to arrow function (Shinya Kanamaru) #17699bdddb82595] - test: check socketOnDrain where needPause is false (Leko) #17654b8265285ff] - test: fix flaky test-benchmark-misc (Rich Trott) #17686b1fd50a773] - test: remove literals that obscure assert messages (Rich Trott) #17642f16eca4383] - test: improve coverage for util.promisify (Mithun Sasidharan) #1759197eaaf907f] - test: remove unused disposed_ variable (Daniel Bevenius) #17628cc683bd0cb] - test: expand test-https-keep-alive-large-write (Anna Henningsen) #175646cb4cc2f1c] - test: fix flaky test-child-process-pass-fd (Rich Trott) #175985cd08d3a59] - test: add unhandled rejection guard (babygoat) #17275b379d8d105] - test: improve crypto/random.js coverage (Leko) #17555bc7dc65229] - test: add test description to fs.readFile tests (Jamie Davis) #1761070588f7f21] - test: simplify common.expectsError (Ruben Bridgewater) #17616fb640c66cb] - timers: remove domain enter and exit (Anatoli Papirovski) #178803997617869] - tls: set servername on client side too (James M Snell) #17935e69ea78974] - tls: fix SNICallback without .server option (Anna Henningsen) #17835b44f245b14] - tls: comment about old-style errors (xortiz) #1775941702ef457] - tls: unconsume stream on destroy (Anna Henningsen) #174785514330406] - tls: use correct class name in deprecation message (Anna Henningsen) #175614dacff72b5] - tools: do not override V8's gitignore (Yang Guo) #18010adc59a3e71] - tools: host remark-preset-lint-node in-tree (Jon Moss) #17441c91a7c09ae] - tools: add check for using process.binding crypto (Daniel Bevenius) #178674391ea4a57] - tools: enable array-callback-return ESLint rule (Rich Trott) #17858b89cda4cbd] - tools: fix AttributeError: __exit__ on Python 2.6 (Dmitriy Kasyanov) #176632d07243cac] - tools: autofixer for lowercase-name-for-primitive (Shobhit Chittora) #177157ef876d89d] - tools: fix man pages linking regex (Diego Rodríguez Baquero) #177246531401cde] - tools: add number-isnan rule (Jon Moss) #17556eaa2d9116a] - tools: simplify lowercase-name-for-primitive rule (cjihrig) #176533ad8cf14f5] - tools: add lowercase-name-for-primitive eslint rule (Weijia Wang) #175687bf6be0b7c] - trace_events: stop tracing agent in process.exit() (Andreas Madsen) #18005ed7f59a1ee] - url: added url fragment lookup table (Hakan Kimeiga) #1762728ef3de2ba] - url: added space to class string of iterator objects (Haejin Jo) #175586d9b1e4c83] - util: allow wildcards in NODE_DEBUG variable (Tyler) #176096cc622f01b] - vm: allow modifying context name in inspector (Timothy Gu) #17720e2767114ff] - vm: never abort on caught syntax error (Anna Henningsen) #173947bf4102db9] - win, build: fix without-intl option (Bartosz Sosnowski) #17614584e74d8cc] - (SEMVER-MINOR) zlib: add ArrayBuffer support (Jem Bezooyen) #16042