stream: improve the error message of ERR_INVALID_ARG_TYPE#17145
Closed
starkwang wants to merge 1 commit into
Closed
stream: improve the error message of ERR_INVALID_ARG_TYPE#17145starkwang wants to merge 1 commit into
ERR_INVALID_ARG_TYPE#17145starkwang wants to merge 1 commit into
Conversation
The `expected` argument of `ERR_INVALID_ARG_TYPE` can be an array, which is better than a single string.
nodejs-github-bot
added
the
stream
apapirovski
approved these changes
Nov 20, 2017
cjihrig
approved these changes
Nov 20, 2017
jasnell
approved these changes
Nov 20, 2017
Trott
approved these changes
Nov 21, 2017
Member
joyeecheung
added
the
fast-track
joyeecheung
approved these changes
Nov 21, 2017
joyeecheung
left a comment
joyeecheung
left a comment
Member
There was a problem hiding this comment.
This does not need 48-hours. LGTM once CI is green
jasnell
pushed a commit
that referenced
this pull request
Nov 22, 2017
The `expected` argument of `ERR_INVALID_ARG_TYPE` can be an array, which is better than a single string. PR-URL: #17145 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Member
|
Landed in 0a948b9 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
The `expected` argument of `ERR_INVALID_ARG_TYPE` can be an array, which is better than a single string. PR-URL: #17145 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
The `expected` argument of `ERR_INVALID_ARG_TYPE` can be an array, which is better than a single string. PR-URL: #17145 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
Contributor
|
Should this have been My apologies if I am mistaken. Please adjust lts labels as appropriate |
Member
|
@MylesBorins The error message prior to the changed one was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
expectedargument ofERR_INVALID_ARG_TYPEcan be an array, which is better than a single string.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
stream