Adds integration tests for Yarn#1022
Merged
Merged
Conversation
Member
Contributor
Author
|
The test failures seem unrelated with my change (I see they occur in main already: https://github.com/nodejs/citgm/actions/runs/6604240669/job/17938186004#step:14:770). |
Member
|
You can disregard the test failure but https://github.com/nodejs/citgm/actions/runs/6652341543 shows multiple failures that may be related. |
Contributor
Author
|
Can you retry them? I think I fixed them in yarnpkg/berry#5875 |
Member
Contributor
Author
|
All green! |
Contributor
Author
|
The three failures seem infra problems: rhel8-ppc64le & fedora-last-latest-x64: |
Member
|
Agreed. |
targos
approved these changes
Oct 29, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 2139 2139
=======================================
Hits 2063 2063
Misses 76 76 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We merged #905 without running the full suite of integration tests to make sure that we were testing at least something. This PR aims to enable a couple of the most important integration tests (still not all of them).
Checklist
npm testpasseshere