Skip to content

Print proper error log when peerAdd fails#2357

Merged
mavenugo merged 1 commit into
moby:masterfrom
mavenugo:win-rs1-ov-bug
Apr 7, 2019
Merged

Print proper error log when peerAdd fails#2357
mavenugo merged 1 commit into
moby:masterfrom
mavenugo:win-rs1-ov-bug

Conversation

@mavenugo

@mavenugo mavenugo commented Apr 6, 2019

Copy link
Copy Markdown
Contributor

Signed-off-by: Madhu Venugopal madhu@docker.com

@dani-docker dani-docker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@selansen

selansen commented Apr 6, 2019

Copy link
Copy Markdown
Contributor

@mavenugo I don't find any osversion package under hcsship. Thats why CI is failing .
Am I missing something ?

drivers/windows/overlay/ov_endpoint_windows.go:10:2: cannot find package "github.com/Microsoft/hcsshim/osversion" in any of:
	/go/src/github.com/docker/libnetwork/vendor/github.com/Microsoft/hcsshim/osversion (vendor tree)
	```

Signed-off-by: Madhu Venugopal <madhu@docker.com>
@mavenugo mavenugo changed the title Print proper error log and use proper windows build constant Print proper error log when peerAdd fails Apr 6, 2019

@selansen selansen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants