Data Path Port configuration support#1509
Merged
Merged
Conversation
selansen
requested review from
albers,
thaJeztah and
vdemeester
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
==========================================
- Coverage 55.22% 55.15% -0.08%
==========================================
Files 289 289
Lines 19384 19376 -8
==========================================
- Hits 10705 10686 -19
- Misses 7983 7997 +14
+ Partials 696 693 -3 |
Contributor
Author
|
@albers @thaJeztah @vdemeester PTAL |
thaJeztah
requested changes
Nov 26, 2018
Member
|
Left some comments; be careful, because GitHub is hiding some of those;
|
thaJeztah
added
impact/changelog
status/2-code-review
impact/documentation
and removed
status/0-triage
labels
This commit brings Swarmkit and docker chnages Signed-off-by: selansen <elango.siva@docker.com>
selansen
force-pushed
the
master
branch
2 times, most recently
from
2eee1a1 to
a01545f
Compare
Contributor
Author
I checked all your review comments multiple times and not sure if I still not seeing any of your comment. Pls let me know if I miss anything. PATL @thaJeztah @albers |
Contributor
Author
|
@thaJeztah Do I still need to make any change? Pls let me know |
albers
approved these changes
Nov 27, 2018
albers
left a comment
albers
left a comment
Collaborator
There was a problem hiding this comment.
bash completion LGTM, thanks.
thaJeztah
requested changes
Nov 27, 2018
Contributor
Author
|
@albers @vdemeester PTAL |
silvin-lubecki
approved these changes
Nov 28, 2018
silvin-lubecki
left a comment
silvin-lubecki
left a comment
Contributor
There was a problem hiding this comment.
Only one comment, LGTM if fixed, thank you @selansen !
This PR chnages allow user to configure data path port number. By default we use 4789 port number. But this commit will allow user to configure port number during swarm init. Data path port can't be modified after swarm init. Signed-off-by: selansen <elango.siva@docker.com>
Contributor
Author
|
@thaJeztah PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR chnages allow user to configure data path
port number. By default we use 4789 port number. But this commit
will allow user to configure port number during swarm init.
Data path port can't be modified after swarm init.
Signed-off-by: selansen elango.siva@docker.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)