build: change --console=[auto,false,true] to --progress=[auto,plain,tty]#1276
Conversation
| return "", fmt.Errorf("sysctl '%s' is not whitelisted", val) | ||
| } | ||
|
|
||
| func ValidateProgressOutput(val string) (string, error) { |
There was a problem hiding this comment.
Do you really need to return a string here?
There was a problem hiding this comment.
I think it's to respect the other validation Validate* signatures, that are able to mutate the value being validated. As we don't really use it into a type that require this signature (and as I'm not found of a validation function mutating the value it validates), I think we shouldn't return a string and just an error
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
Design LGTM
Small comment on the code, and there is a linter issue too 👼
| return "", fmt.Errorf("sysctl '%s' is not whitelisted", val) | ||
| } | ||
|
|
||
| func ValidateProgressOutput(val string) (string, error) { |
There was a problem hiding this comment.
I think it's to respect the other validation Validate* signatures, that are able to mutate the value being validated. As we don't really use it into a type that require this signature (and as I'm not found of a validation function mutating the value it validates), I think we shouldn't return a string and just an error
tiborvass
force-pushed
the
buildkit-progress-flag
branch
from
60be7af to
31fccd0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
+ Coverage 54.29% 54.32% +0.02%
==========================================
Files 268 268
Lines 17855 17847 -8
==========================================
Hits 9695 9695
+ Misses 7550 7542 -8
Partials 610 610 |
This changes the experimental --console flag to --progress following feedback indicating avoidable confusion. In addition to naming changes, the help output now has an additional clarification, specifically: container output during builds are only shown when progress output is set to plain. Not mentioning this was also a big cause of confusion. Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
buildkit-progress-flag
branch
from
31fccd0 to
faeb8bb
Compare
|
@vdemeester @AntaresS fixed! |
5 participants
This changes the experimental --console flag to --progress following
feedback indicating avoidable confusion.
In addition to naming changes, the help output now has an additional
clarification, specifically: container output during builds are only
shown when progress output is set to plain. Not mentioning this was also
a big cause of confusion.
Signed-off-by: Tibor Vass tibor@docker.com