You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
The existing node cache key does not take architecture into consideration. However during npm/yarn/etc installing the dependencies may generate different binaries based on the current architecture. Thus if the workflow has matrix that spawn different jobs on different architectures for the same platform may consume the same cache, which might be wrong.
This PR adds the arch to the cached key.
Related issue:
Add link to the related issue.
Check list:
Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.
Hello,
This pull request fixes the issue described in issue by adding the architecture to the cache key. I tested this change on my repository and it works fine.
Do you know when this pr will be merged ?
Thanks to @pengx17 for his work
Hello @pengx17, Could you please update the line os.platform() with process.env.RUNNER_OS to maintain the existing value of process.env.RUNNER_OS for better consistency and clarity with the runner name.
Hello @pengx17, a gentle follow up to update the line os.platform() with process.env.RUNNER_OS to maintain the existing value of process.env.RUNNER_OS for better consistency and clarity with the runner name.
Hello @pengx17, a gentle follow up to update the line os.platform() with process.env.RUNNER_OS to maintain the existing value of process.env.RUNNER_OS for better consistency and clarity with the runner name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
✕
Wait! Don't Go Yet 🚀
Get our FREE eBook "10 Programming Tips That Changed Everything" when you subscribe!
Description:
The existing node cache key does not take architecture into consideration. However during npm/yarn/etc installing the dependencies may generate different binaries based on the current architecture. Thus if the workflow has matrix that spawn different jobs on different architectures for the same platform may consume the same cache, which might be wrong.
This PR adds the arch to the cached key.
Related issue:
Add link to the related issue.
Check list: