Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
GitHub Community
New commit details page (public beta) feedback #139005
Replies: 171 comments 207 replies
-
|
My first reaction to the new page was: What is happening now!?! My second impression was: why is everything 50% bigger, did I Ctrl+Scroll to zoom by accident? And my third was: where are the diff count squares? Also I just found the first bug: when having text selected and trying to extend that selection with shift, that no longer works. Also I was just searching a bit for a commit message because since it is now completely grey, I kinda missed it. |
Beta Was this translation helpful? Give feedback.
-
|
Fully agreement re the font size increase. I feel like I'm reading a blog that embedded in a code snippet but inherited font settings from the surrounding, non-code webpage. |
Beta Was this translation helpful? Give feedback.
-
|
Some of you have already found it, but if not ... we shipped a new user setting today (Compact line height) that lets you toggle between compact and regular line height. This is saved with your user profile, so if you prefer a more compact line height, you only need to toggle this once.
We are still listening to feedback on this, so keep it coming. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
Is this setting meant to be only about the line-height of the diff itself? Do the I understand the problem of users, who need bigger buttons and more space around them. But these changes also make the workflow of users, who don't have large screens, less comfortable. E.g I work on a 13" or 14" laptop (at my home office, from a coffee shop, co-working or a train). |
Beta Was this translation helpful? Give feedback.
-
We'll be reducing the height/padding on the header as well (for everyone, not just if you have "compact line height" enabled). |
Beta Was this translation helpful? Give feedback.
-
|
I personally dislike the new page's design. |
Beta Was this translation helpful? Give feedback.
-
|
I really don't like the line height change. I view a diff because I want to see what changed. Having a larger line height now means I have to keep scrolling up and down more, and I can't fit as much lines in my line of sight. It's annoying. |
Beta Was this translation helpful? Give feedback.
-
|
My IDE has enormous spacing, so generally I am for it, but for diff view I agree it shouldn't be spaced out, we NEED to see things in context for diffs so this makes it less useable. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback here. We are working on a new user setting that will let you control how compact (or not) the spacing is. Look for Compact line height user setting in the discussion description above for our current thinking, background, etc, and let us know what you think! |
Beta Was this translation helpful? Give feedback.
-
|
+1 for customizability in line-spacing. The current default is very weird - I had to double check if there wasn't a stray newline in my generated JSON files. |
Beta Was this translation helpful? Give feedback.
-
I assume you're joking about the appearance of a stray newline (😄), but if you're not ... The current line height is 24px and the font-size is 12px, which means there should be 2-3px above and below the text on each line (so 4-6px between each line, or about 1/4 or 1/3 of the text height). If you're seeing something more than this, please send a screen shot. |
Beta Was this translation helpful? Give feedback.
-
|
I cant see now how my files have been changed by size, thats not good |
Beta Was this translation helpful? Give feedback.
-
|
This is because the diff stat visuals (green and red boxes) no longer appear, correct? |
Beta Was this translation helpful? Give feedback.
-
|
Yes, it'd be nice if it was switched over to the ones used in the 'New Pull Request Commits Experience' beta. |
Beta Was this translation helpful? Give feedback.
-
|
@willsmythe Yeah, it was really usefull for me, also i dont like the gaps too, also thought i was zoomed in my Firefox tab haha |
Beta Was this translation helpful? Give feedback.
-
|
We shipped a fix last night to bring back the diff stat visuals (and also show the +/- numbers). Let us know what you think!
(see the Recent fixes and enhancements ✅ section in the discussion description for this and other recent fixes) |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
Yes please, I'd really appreciate this exact option to disable the floating comments and switch back to the current design. I'm honestly not a fan of floating comments - they seem to have been designed with very short comments in mind (e.g. one sentence), in which case I understand some people might like it better, but reading longer comments or discussions in that little floating box is very inconvenient (for instance, see kaitai-io/kaitai_struct_compiler@6500c68#r122025444 or kaitai-io/kaitai_struct_compiler@6500c68#r121976601). |
Beta Was this translation helpful? Give feedback.
-
|
Also, if I try editing the floating comment, I can see that it doesn't respect my setting of Use a fixed-width (monospace) font when editing Markdown (https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/about-writing-and-formatting-on-github#enabling-fixed-width-fonts-in-the-editor), because the textarea there apparently uses a proportional font (unlike all the other places where I can write or edit comments):
|
Beta Was this translation helpful? Give feedback.
-
Thanks for the feedback. We are tracking this, and I've listed it in the description under Known Issues. |
Beta Was this translation helpful? Give feedback.
-
|
Okay |
Beta Was this translation helpful? Give feedback.
-
|
Ok |
Beta Was this translation helpful? Give feedback.
-
|
My feedback is, thank you for putting the green "beta" mark with a link to this post explaining. I like the new design, but when it happened, I was in the middle of writing comments on a commit and it was very confusing to me why the design changed. I thought for a little while that the project maintainer was collapsing my comments until I found the link to this page. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for this feedback! This new page will be fully rolled out (in beta) by today, but we have other beta features that will be shipping soon, and we'll make sure to test this flow to ensure nothing breaks (and the experience is not confusing). |
Beta Was this translation helpful? Give feedback.
-
|
That's odd, because my page says "Alpha". I would argue that its live, and there is no way to toggle the page back then you can't really call it a beta. |
Beta Was this translation helpful? Give feedback.
-
|
The problem (as mentioned by others), isn't the scaling, the scaling is actually the same as before. The issue is the If this is for accessibility purposes, then it should be it's own feature preview or option that the user can toggle. Another issue that's not mentioned yet is that commits with really long descriptions now have a "Show more" button instead of just showing the full description. If I'm clicking on a commit, I probably want to read the description. Please don't make me click multiple times. The text could also be made brighter and easier to read as it was before. See with this example commit: mpv-player/mpv@d2f3b66 |
Beta Was this translation helpful? Give feedback.
-
We rolled out a fix for this 🎉. See "Recent fixes and enhancements ✅" above. |
Beta Was this translation helpful? Give feedback.
-
We also just rolled out a new setting that lets you control line height (see description). |
Beta Was this translation helpful? Give feedback.
-
|
I dislike that the file name and path gets shortened despite there being plenty of horizontal space in the bar. And I can't even hover it to get the full path, I have to hover the "expand" button for the purpose of this screenshot. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback. Agree --- there's no reason to truncate the file path when there's plenty of space to show it. I opened an issue. |
Beta Was this translation helpful? Give feedback.
-
|
A fix rolled out for this last night! 🎉 Take a look and let us know if you're still seeing a problem. |
Beta Was this translation helpful? Give feedback.
-
|
Honestly, I liked the old design better. I hope there will be an option to switch between them. |
Beta Was this translation helpful? Give feedback.
-
I appreciate the question, but I believe this is largely a matter of personal preference. In my case, I simply prefer the old design, likely because I’m more used to it. As @alphapapa pointed out, "If it’s not broken, why fix it?", especially with something as critical as this. In any case, if we're really going to stick to this design, please fix the reported bugs. I noticed a lot of issues with spacing, for example, the fact that the comments box doesn't match the width of the diff view (see the two attached pictures for reference - old vs new).
The empty space marked in blue could easily be utilized by the comments box - at least, that’s how it used to work before (and it looked just fine IMHO). Another (very) annoying issue I’ve noticed is that the indentation appears to be broken in some cases. See this commit for example. |
Beta Was this translation helpful? Give feedback.
-
|
I personally agree with @R0rt1z2, I like that github now finally seems to fit the code view to the full width of the screen (which it previously did not do on 4K displays) but the function call navigation and file navigation sidebars are annoying. I understand the usage of the sidebar navigation but I wish that explicitly dismissing it would keep it hidden and not reopen it when I click, highlight, or navigate in the code. Much like @R0rt1z2, this is mostly personal preference, some of which I fixed with greasemonkey scripts but I still feel the behavior is incorrect. I also agree with the comment box width problem. For a long time, GitHub had used explicit pixel widths for many elements instead of using relative spacing and this made viewing on 4K or higher resolution displays quite annoying. |
Beta Was this translation helpful? Give feedback.
-
Thanks for the feedback. We're looking into it. |
Beta Was this translation helpful? Give feedback.
-
@R0rt1z2 - we rolled out a fix for indentation issues on some browsers. Can you see if it resolves your issue with viewing this commit? |
Beta Was this translation helpful? Give feedback.
-
@willsmythe It seems to be working fine now. I tried with that commit, and the indentation looks correct. I'm using Firefox on Windows.
|
Beta Was this translation helpful? Give feedback.
-
|
... I can't right click to copy/paste the code? |
Beta Was this translation helpful? Give feedback.
-
|
aha – I guess then it doesn't work because, when I right-click, my selection is cleared. |
Beta Was this translation helpful? Give feedback.
-
Noticed this too; selection should (also) stay. |
Beta Was this translation helpful? Give feedback.
-
How about just not hijacking the native right-click behavior? |
Beta Was this translation helpful? Give feedback.
-
|
Try? |
Beta Was this translation helpful? Give feedback.
-
|
This public discutions can i commented too? |
Beta Was this translation helpful? Give feedback.
-
|
The new design seems to struggle with tab indentation in files. For the sake of completeness I'll mention that the below screenshots are using 4-space tabs in my user settings but the effect in the new design is the same with the default of 8. Old: New: |
Beta Was this translation helpful? Give feedback.
-
|
seems like it's just "swallowing" the first tab, and even more because the first letter is cut off
|
Beta Was this translation helpful? Give feedback.
-
|
I saw just the new commit page for the first time today and it's not understandable to me how Github has not stopped the beta rollout when there's such an obvious bug. |
Beta Was this translation helpful? Give feedback.
-
|
What browser/OS are you all on, and do you have any plugins for GitHub installed? |
Beta Was this translation helpful? Give feedback.
-
|
Firefox on Linux (X11). No plugins or CSS modifications for GH. |
Beta Was this translation helpful? Give feedback.
-
|
The default-collapsed commit text seems to utterly miss the point of the commit details page. It's also much harder to read – the previous page used #1f2328 on #f1f8ff, which has an excellent contrast of Lc 98.0, but the new page uses #59636e on #fff which works out to only Lc 80.5, which is well below the preliminary APCA Bronze threshold of Lc 90. In conjunction with the smaller font size (was 13px, now 12px), the commit text is now very difficult for me to read. Duplicating the first line of the commit text (once in the big heading, once in the monospace body) seems a bit odd:
Lastly, the line-height of the code is uncomfortably large, I really hope you don't intend to use this style across the whole website going forwards. |
Beta Was this translation helpful? Give feedback.
-
|
Ugh, thanks for pointing out the contrast change. Haven't we learned that light-gray-text-on-white is an anti-pattern by now? |
Beta Was this translation helpful? Give feedback.
-
|
I agree, the commit message is much harder to read because of the light gray and shouldn't be collapsed. I don't understand why it feels like there's an aim to de-emphasize the commit message, it's often more important than the code itself! |
Beta Was this translation helpful? Give feedback.
-
|
A fix for the text color problem has rolled out. You should also now see the full commit message. 🎉 |
Beta Was this translation helpful? Give feedback.
-
|
Great |
Beta Was this translation helpful? Give feedback.
-
|
When you start writing a comment, the textbox now expands off-screen:
so you have to scroll down again to see the button to submit the comment now. If the comment box were not collapsed by default, this would be solved. The page also doesn't seem to have the standard GitHub footer, which doesn't help. On wide screens (and by "wide" I mean "16:9 1440p"), having to mouse all the way over to the right-hand side to add a comment makes it really hard to see which line you're commenting on (unless you want to open the dialog, check the line number on the right (which says "R" for some reason?), pull your eyes back to the left-hand side to check the line number there, and try again if you aimed wrong):
And the tooltips on the comment widget buttons ("Heading", "Bold", etc.) appear to have been dropped, which sucks. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for reporting. The team is working on a fix. |
Beta Was this translation helpful? Give feedback.
-
|
Links to diffs for specific ranges no longer work. The page does not correctly focus the view on the range present in the URL (for example, the URL ending with |
Beta Was this translation helpful? Give feedback.
-
|
I am a heavy mobile user and I need to review code on the go... 
There is so much wasted horizontal space and the wrapping makes things even worse. This makes reading code unbearable... I'd almost say impossible. I've been using a userscript before the new design that made a few css adjustments but seeing that this isn't possible anymore makes this even more frustrating. |
Beta Was this translation helpful? Give feedback.
-
|
One solution for this is to just stop wrapping things. It makes stuff so harder to read on width constrained devices. Or at least let the user toggle the wrapping behavior. |
Beta Was this translation helpful? Give feedback.
-
|
Also the spacing/heights of the file header is just way too big. Again, on mobile this is way worse than desktop. |
Beta Was this translation helpful? Give feedback.
-
Thanks for the feedback. We are exploring adding a user setting, similar to the "wrap lines" setting we have when viewing a file. |
Beta Was this translation helpful? Give feedback.
-
|
Some code can be borderline unreadable on mobile |
Beta Was this translation helpful? Give feedback.
-
|
I just permanently enabled Desktop Mode on my mobile for GitHub links, because the mobile site was already unbearable. Both old and new. |
Beta Was this translation helpful? Give feedback.
-
|
I'm seeing this kind of output even on the desktop. Would prefer to keep things as they were. |
Beta Was this translation helpful? Give feedback.
-
|
Same, this happens on desktop too. I should be able to scroll to see the whole line. Line wrap is not useful here. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback. We are working on a fix for tab/indent behavior, and also exploring adding a user setting to toggle line wrapping. |
Beta Was this translation helpful? Give feedback.
-
|
This should be resolved - are you all still seeing the problem? |
Beta Was this translation helpful? Give feedback.
-
|
Capturing ctrl+F to only search code is a pain in the ass. I typically use it to jump to a file in the PR preview, and now that workflow is broken. |
Beta Was this translation helpful? Give feedback.
-
|
Agreee, I also use it for "search everything". I hate it every time those essential features get overloaded. |
Beta Was this translation helpful? Give feedback.
-
My bad, I've suggested If you prefer to assign each scope, code and global, a dedicated search shortcut without repetition, |
Beta Was this translation helpful? Give feedback.
-
|
It's great to see the GitHub team working on updating the commit view! I do wonder though, is allowing commenting on commit messages rather than just the diffs on the roadmap for this feature? https://github.com/orgs/community/discussions/4983 https://github.com/orgs/community/discussions/56449 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
It seems that comments on commits no longer load. They stay in this loading animation forever: Example: phpstan/phpstan-src@f38addd The interesting thing is, that as soon as I open the page in Incognito the comments do show up. |
Beta Was this translation helpful? Give feedback.
-
|
Navigation through commits with keyboard shortcuts does not work: P or O for going to the (other) parent commit |
Beta Was this translation helpful? Give feedback.
-
|
شكرا لك سوف نراجع هاذا الامر |
Beta Was this translation helpful? Give feedback.
-
|
I was trying to find time a commit occurred, but this does not seem possible. Instead the page just says 'committed yesterday' which while helpful is not helpful enough. |
Beta Was this translation helpful? Give feedback.
-
|
شكرا |
Beta Was this translation helpful? Give feedback.
-
|
This should be fixed by now, dates are shown again |
Beta Was this translation helpful? Give feedback.
-
|
Bring back binary files size comparison in commit view |
Beta Was this translation helpful? Give feedback.
-
|
It's hard to find given how comments are hidden above, but I also reported this a couple weeks ago. It would be great to have file sizes back. |
Beta Was this translation helpful? Give feedback.
-
|
وضح اكثر |
Beta Was this translation helpful? Give feedback.
-
|
Essentially this cause: Plus the currently janky anchor navigation in Discussions... |
Beta Was this translation helpful? Give feedback.
-
|
شكرا جزلا لك لقد تلقينا رسالتك ونعمال علا حلها في اقرب وقت
في الخميس، ٣ تشرين الأول، ٢٠٢٤، ٤:٣٣ ص MasterInQuestion <
***@***.***> كتب:
… Essentially this cause:
#139005 (reply in thread)
Plus the currently janky anchor navigation in Discussions...
—
Reply to this email directly, view it on GitHub
<#139005 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6Q3IALB3RNU2XR6GAGZ2MDZZSNH7AVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAOBSGY3DINY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks for your exotic tone that bringing the problem more extraordinariness. |
Beta Was this translation helpful? Give feedback.
-
|
عفوان |
Beta Was this translation helpful? Give feedback.
-
|
هاذا ليس تبرير نحن نعتدر منك بلفعل
في الخميس، ٣ تشرين الأول، ٢٠٢٤، ٥:٠٨ ص MasterInQuestion <
***@***.***> كتب:
… Thanks for your exotic tone that bringing the problem more
extraordinariness.
—
Reply to this email directly, view it on GitHub
<#139005 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6Q3IAI4LHYMURCNGW5CYXDZZSRK7AVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAOBSGY4DCNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
While I really like this change, The only problem I have is the amount of space between the lines. I know there's an option to make it more compact, But it should be an accessibility setting instead and have the compact version be the default. Personally, I would like to see more of the file at once so I don't have to scroll so much to find stuff or read through commits. Other than that, I'm really happy with the change. I wish y'all the best <3 |
Beta Was this translation helpful? Give feedback.
-
|
شكرا لك سوف نجعله اكثر ختصار |
Beta Was this translation helpful? Give feedback.
-
|
The new commit details view is unbearably slow. It's slow much slower than the non-beta view. |
Beta Was this translation helpful? Give feedback.
-
|
I suggest to add a shortcut to compare. It's usual the need to compare, for example, a specific commit with latest version of the same files |
Beta Was this translation helpful? Give feedback.
-
|
لاتقلق نحنا نعمل من اجلك
في الخميس، ٣ تشرين الأول، ٢٠٢٤، ١١:٤٦ ص Jan Six ***@***.***>
كتب:
… This should be fixed by now, dates are shown again
—
Reply to this email directly, view it on GitHub
<#139005 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6Q3IALKQZM7FKSC6FDTISTZZT75TAVCNFSM6AAAAABON5D7AGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAOBSHE2DSMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
|
The cache gets broken or something on brave. The first time i visited the page I was able to comment, now it perpetually loads. I can open this in an incognito tab just fine. It has been a pretty poor experience so far since I am not unable to even interact with the commit. |
Beta Was this translation helpful? Give feedback.
-
|
What was so wrong with the old page? What problem are we trying to resolve with a rewrite? Could we not take a more incremental approach? |
Beta Was this translation helpful? Give feedback.
-
|
Comment is broken - I can't load my comment |
Beta Was this translation helpful? Give feedback.
and others
-
A new version of the commit details page is now available in public beta! This new page, which is enabled by default, lets you quickly understand and navigate the changes in a commit with improvements to filtering, commenting, and keyboard navigation!
What's new 🎉
Here are a few of the noteworthy changes:
upanddownkeys on your keyboard. A new context menu also makes it easier to comment, copy, and select.To opt out of the preview, go the Feature Preview dialog on your profile, select New Commit Page, and click Disable.
Let us know what you think!
Investigating 🟨
Things we are discussing and investigating internally (and we welcome your feedback on):
Known issues 🔴
#diff-e727e4R4-R7).) appears before file name in header above diff.gitattributesnot presented as generated)@mention menu does not appear when adding/editing inline commentsIn progress 🧡
(updates coming)
Recent fixes and enhancements ✅
Week of September 16:
Copymenu option not appearing for some users ✅Week of September 23
Screen.Recording.2024-09-26.at.11.34.46.AM.mov
More about compact line height
* Compact line height user setting 🆕: * **What's our plan?** Based on your feedback about the height of diff lines in the new parge, we are adding a user setting under the ⚙️ that you can enable if you want more compact lines. When enabled, the height of diff lines will be `20px` (same as the classic commit details page), otherwise (and by default) they will be `24px`. * **Why a user setting?** It is important that this (and every) page on GitHub is accessible to everyone. [WCAG recommends a minimum of `24x24px` for click targets](https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html) because _some people with physical impairments cannot click small buttons that are close together_. The avatar (which appear when there are comments on a line) and button to add a comment are both important click targets on the line, which is why the default height of the line is 24px. We recognize that some users prefer (and are able to interact with) more compact lines and click targets, which is why we are introducing a user setting.
Beta Was this translation helpful? Give feedback.
All reactions