The Wayback Machine - https://web.archive.org/web/20240528063657/https://github.com/oasis-tcs/sarif-spec/issues/69
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a physicalLocation on a stack frame #69

Closed
michaelcfanning opened this issue Nov 13, 2017 · 1 comment
Closed

Provide a physicalLocation on a stack frame #69

michaelcfanning opened this issue Nov 13, 2017 · 1 comment

Comments

@michaelcfanning
Copy link
Contributor

We currently break out uri, uriBaseId, etc. on a stack frame instead of putting a physicalLocation on it. I think the reason is that we didn't see value in providing all the information in a physicalLocation (a region doesn't exactly make sense for a stack frame).

I think it might be preferable to simply have the physicalLocation object, though, with the caveat that its region data is not likely to cover a multi-line span.

@michaelcfanning michaelcfanning changed the title Consider providing a physicalLocation on a stack frame Provide a physicalLocation on a stack frame Dec 13, 2017
ghost pushed a commit that referenced this issue Jan 11, 2018
@ghost ghost added the resolved-fixed label Jan 11, 2018
@ghost ghost self-assigned this Jan 11, 2018
@ghost
Copy link

ghost commented Jan 11, 2018

Closed in c443e9a.

@ghost ghost closed this as completed Jan 11, 2018
michaelcfanning added a commit that referenced this issue Nov 9, 2022
Minutes for SARIF TC meeting #69, 2022/10/27.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant