The Wayback Machine - https://web.archive.org/web/20240527113918/https://github.com/oasis-tcs/sarif-spec/issues/404
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

On tool failure, run.results is optional and defaults to null #404

Closed
ghost opened this issue Apr 30, 2019 · 0 comments
Closed

On tool failure, run.results is optional and defaults to null #404

ghost opened this issue Apr 30, 2019 · 0 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. bug impact-non-breaking-change merged Changes merged into provisional draft. resolved-fixed

Comments

@ghost
Copy link

ghost commented Apr 30, 2019

There's no reason to require it to be present with null value. Making it default to null allows simpler serialization if the SDK fails before producing a results array.

@michaelcfanning @kupsch

@ghost ghost added bug impact-non-breaking-change 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. labels Apr 30, 2019
@ghost ghost self-assigned this Apr 30, 2019
@ghost ghost added merged Changes merged into provisional draft. resolved-fixed labels Apr 30, 2019
@ghost ghost changed the title run.results is optional and defaults to null On tool failure, run.results is optional and defaults to null Apr 30, 2019
@ghost ghost closed this as completed Apr 30, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. bug impact-non-breaking-change merged Changes merged into provisional draft. resolved-fixed
Projects
None yet
Development

No branches or pull requests

0 participants