GitHub Community
Comment on Files in a Pull Request (Beta) Feedback #49954
Replies: 86 suggested answers 40 replies
-
|
Thank you for adding this feature, I typically leave general comments linked to the bottom line of a file; it'll be much nicer to leave a more general comment. 🙏🏻 |
Beta Was this translation helpful? Give feedback.
-
|
My team in my previous company used to do something similar, but adding a comment to the first line of a file (which is also not ideal). |
Beta Was this translation helpful? Give feedback.
-
|
yea me too, except that I put my comment in the middle of the file |
Beta Was this translation helpful? Give feedback.
-
|
@giovanni-nabil what if the file has an even number of lines? Where do you place your comment? |
Beta Was this translation helpful? Give feedback.
-
@sjaramillo10 Those files made this practice really cumbersome :) |
Beta Was this translation helpful? Give feedback.
-
|
Love this! This is going to be super useful |
Beta Was this translation helpful? Give feedback.
{{title}}
{{editor}}'s edit
{{editor}}'s edit
-
|
love this too, hooray ~ |
Beta Was this translation helpful? Give feedback.
{{title}}
{{editor}}'s edit
{{editor}}'s edit
-
|
Love this direction! Feedback: It seems that leaving a file-level review comment on a deleted file right now shows that comment as Outdated and isn't displayed in the file view, only being visible in the conversation timeline. |
Beta Was this translation helpful? Give feedback.
-
|
@arthurljones @daneah thank you very much for the feedback. I do suspect that force-pushing is a partial culprit, and it's interesting that it occurred on a file moved between directories. Either way I'm looking into this more and will hopefully have this addressed soon. |
Beta Was this translation helpful? Give feedback.
{{title}}
{{editor}}'s edit
{{editor}}'s edit
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
I have a bit more data - after copying over all my full-file comments to new comments so they would show up inline, I didn't want to deal with the same issue again, so I went ahead and pushed a commit (I can always squash and merge). However, even just pushing a commit caused every full-file comment to be marked outdated, whether it was on a deleted file or not. Also, none of my files were moved. |
Beta Was this translation helpful? Give feedback.
-
|
Ah! I can bet that is what triggered mine as well. |
Beta Was this translation helpful? Give feedback.
{{title}}
{{editor}}'s edit
{{editor}}'s edit
-
|
More or less the same here:
The overall feature idea is cool, but I’ll wait for it to be less outdatedness-prone before using it. |
Beta Was this translation helpful? Give feedback.
-
|
This is super useful, previously I needed to add generic comments mentioning files, now this will point to the exact file |
Beta Was this translation helpful? Give feedback.
-
|
I've always wanted this! thank you for adding it! |
Beta Was this translation helpful? Give feedback.
-
|
This is great! In addition to:
it also enables adding a comment on an empty file that was accidentally committed, which coincidentally I had to work around just a few hours ago, but now I can comment directly on it Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Yes, this and binary file comments are not possible otherwise. |
Beta Was this translation helpful? Give feedback.
-
|
Nice - thanks for implementing this! |
Beta Was this translation helpful? Give feedback.
-
|
Awesome! |
Beta Was this translation helpful? Give feedback.
-
|
Great! |
Beta Was this translation helpful? Give feedback.
-
|
Hurrah! (A related ask: Can we get keyboard shortcuts to initiate a code comment--on a line or a file--when reviewing? Thanks.) |
Beta Was this translation helpful? Give feedback.
-
|
A nice feature, I was adding comments for the first line of the file before |
Beta Was this translation helpful? Give feedback.
-
|
Awesome feature..!!! I just used it on a PR. |
Beta Was this translation helpful? Give feedback.
-
|
Really nice! Long awaited feature on my end! |
Beta Was this translation helpful? Give feedback.
-
|
This will be great! There is a z-indexing issue currently. |
Beta Was this translation helpful? Give feedback.
-
|
+1 on Arc Browser
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks! We'll get this fixed. |
Beta Was this translation helpful? Give feedback.
-
|
FYI. The fix for this rolled out earlier today. |
Beta Was this translation helpful? Give feedback.
-
|
Looks great! until now I either left a comment on the 1st line or in a random place stating this it's not related specifically to this line |
Beta Was this translation helpful? Give feedback.
-
|
This is fantastic! I've often just made comments at the top of a file and it gets confusing. Tried it out today and it works like a charm! |
Beta Was this translation helpful? Give feedback.
-
|
Can't general comments about files to be located in the review comments? |
Beta Was this translation helpful? Give feedback.
-
|
Always wanted this. It lacked a way to put general comments for a whole file 🙏🏽 Thanks |
Beta Was this translation helpful? Give feedback.
-
|
Does it support commenting on the files that were not changed by one of the commits in that PR? |
Beta Was this translation helpful? Give feedback.
-
|
No |
Beta Was this translation helpful? Give feedback.
-
|
for this see #9099 |
Beta Was this translation helpful? Give feedback.
-
|
Before, I used to include generic comments that referred to files, but now with this new feature, I can directly reference the specific file. It's a total game-changer! |
Beta Was this translation helpful? Give feedback.
-
|
This is useful for leaving a comment on a PR so that other people can "reply" to it in a thread. Could you extend this so that "standalone" comments in PRs also create a reply-able thread? |
Beta Was this translation helpful? Give feedback.
-
Automation |
Beta Was this translation helpful? Give feedback.
-
|
Great job! |
Beta Was this translation helpful? Give feedback.
-
|
Cool, I love this. Feedback 1: When you mark a file as viewed or collapse it, the comment is still visible, which makes it take up a lot of vertical space. I mark them as viewed / collapsed when I'm done thinking about the file, and don't want it taking up space and attention, so I'd rather the comment is not visible then. Perhaps showing in the bar with the filename how many comments are in the file would make it still known when there's a comment on a collapsed file without taking up attention. And you could also have it count comments within the file, which would make it easier to see which files there's discussion on when you have 20 collapsed files in a review, without having to open every one.
Feedback 2: Sometimes I put comments on arbitrary lines when I want to have a threaded discussion instead of it being part of the main PR comment thread. If you could reply to/resolve PR comments that aren't attached to a line/file, or if you could make feedback comments that aren't attached to a line or file, that could remove another reason for putting comments on lines that they don't belong to. (In my mental model, there's a distinction between discussions for specific pieces of feedback, which should be threadable/resolvable and might or might not belong to a line or file, and overall comments which belong in the main thread.) |
Beta Was this translation helpful? Give feedback.
-
|
This is great and something I've long wanted. I would also like the ability to comment on lines in a file that were NOT changed. |
Beta Was this translation helpful? Give feedback.
-
|
On Mon, Mar 27, 2023 at 2:50 AM, Dohyun Ahn ***@***.***> wrote:
love this too, horay ~
--
Sent from iPhone
|
Beta Was this translation helpful? Give feedback.
-
|
Thank you for introducing this feature. |
Beta Was this translation helpful? Give feedback.
-
|
Since this is in Beta, it'd be nice to be able to suggest File Renaming, I believe there is no such suggestion capability. The suggestion can be similar to Code Change Suggestions, instead the change will suggested for the file name, and the user can commit directly from the Suggestion which renames the file to the suggested one. Thanks for this feature, its really helpful. |
Beta Was this translation helpful? Give feedback.
and others
{{title}}
{{editor}}'s edit
{{editor}}'s edit
-
Commenting on a file in a pull request (not just a specific line) will start rolling out to select repos over the next few days🎉
This will allow you to comment on deleted, binary (including images), and renamed files in a pull request. You can also comment generally about a changed code file without having to attach the comment to a specific line.
See the changelog for more details.
Known issues
Tell us what you think
Let us know if you run into problems, have questions, have a request, or just wanna say how useful (or not) this feature is!
Beta Was this translation helpful? Give feedback.
All reactions