bpo-37962: Improve ISO 8601 timezone support in the datetime.fromisoformat() method (GH-15547)#15547
Closed
zeth wants to merge 5 commits into
Closed
bpo-37962: Improve ISO 8601 timezone support in the datetime.fromisoformat() method (GH-15547)#15547zeth wants to merge 5 commits into
zeth wants to merge 5 commits into
Conversation
zeth
changed the title
Member
|
Per the discussion on the discourse and elsewhere, I think we are going to decline this particular PR in favor of a more full-featured ISO 8601 parsing, hopefully before Python 3.9. Thank you for your contribution @zeth, it is much appreciated, please do not let this discourage you from making future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the datetime.fromisoformat() method more conformant with ISO 8601.
Namely, section 4.2.5.1: "When it is required to indicate the difference between local time and UTC of day, the representation of the difference can be expressed in hours and minutes, or hours only."
And Section 4.2.4, UTC shall be expressed "by the UTC designator [Z]".
A key use case of the latter is being able to parse JavaScript Date objects (e.g. dates that have come from a web frontend or a JSON document). This considerably improves the usefulness of the datetime.fromisoformat method.
https://bugs.python.org/issue37962