Skip to content

[tests-only] [full-ci] Run tests with MariaDb 10.6#39282

Closed
phil-davis wants to merge 5 commits into
masterfrom
test-mariadb-10.6
Closed

[tests-only] [full-ci] Run tests with MariaDb 10.6#39282
phil-davis wants to merge 5 commits into
masterfrom
test-mariadb-10.6

Conversation

@phil-davis

@phil-davis phil-davis commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

see if there is even a docker image for MariaDb 10.6

Issue #39283

@phil-davis phil-davis self-assigned this Sep 23, 2021
@phil-davis phil-davis mentioned this pull request Sep 24, 2021
Should default to DYNAMIC
@IljaN

IljaN commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Not sure where this is coming from: https://drone.owncloud.com/owncloud/core/32640/21/5

@IljaN

IljaN commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

I guess @janackermann was correct, it looks to me as if doctrine is creating all tables with default compressed

@IljaN

IljaN commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Found another instance of "compressed": ec94749

@IljaN

IljaN commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Are there more configs which set row_format?

@IljaN

IljaN commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

So unit tests pass with my commits on 10.6 now, but some acceptance tests are pulling the 10.7 tarball. What now @phil-davis ?

@phil-davis

Copy link
Copy Markdown
Contributor Author

So unit tests pass with my commits on 10.6 now, but some acceptance tests are pulling the 10.7 tarball. What now @phil-davis ?

https://drone.owncloud.com/owncloud/core/32643/103/11 is using the "latest" tarball to install a federated server = 10.8.0

Actually we don't care what database the federated server is using - we just care that it is running the latest release, so that we test that the newer code in core master still talks correctly with a "latest" federated server.

I will change that back to MariaDb 10.5 for the federated server.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@phil-davis

Copy link
Copy Markdown
Contributor Author

That's good - all tests passed. For new installations it seems like this will be the only code changes needed.

We will have to investigate what issues there might be, if any, for existing sites that are on oC 10.8.0 or earlier, upgrade to a future 10.9.0 and then update MariaDb to 10.6.

@phil-davis phil-davis mentioned this pull request Sep 25, 2021
11 tasks
@phil-davis

Copy link
Copy Markdown
Contributor Author

PR #39286 implements this and has been merged to master.

@phil-davis phil-davis closed this Oct 6, 2021
@phil-davis phil-davis deleted the test-mariadb-10.6 branch October 6, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants