Skip to content

docs: Update npm-doctor.md#6800

Merged
wraithgar merged 6 commits into
npm:latestfrom
siemhesda:patch-3
Sep 18, 2023
Merged

docs: Update npm-doctor.md#6800
wraithgar merged 6 commits into
npm:latestfrom
siemhesda:patch-3

Conversation

@siemhesda

Copy link
Copy Markdown
Contributor

Changing description under npm doctor command to make it clearer

@siemhesda siemhesda requested a review from a team as a code owner September 12, 2023 19:55
@wraithgar

Copy link
Copy Markdown
Contributor

You're gonna want to run npm snap to update the docs snapshots I believe

@wraithgar

Copy link
Copy Markdown
Contributor

Apparently not!

@wraithgar

wraithgar commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

Oh now I remember. You need to change the description attribute in lib/commands/doctor.js and then run npm run build -w docs. You'll also want to run npm run snap to update the test snapshots for the help output for the cli itself.

@siemhesda

Copy link
Copy Markdown
Contributor Author

Hi @wraithgar,
Check it out once more?

@wraithgar

Copy link
Copy Markdown
Contributor

You still need to commit the results of npm run snap

@siemhesda

Copy link
Copy Markdown
Contributor Author

Hi @wraithgar why are we tracking node_modules in the .gitignore line 30

@wraithgar

Copy link
Copy Markdown
Contributor

npm "vendors" its node_modules, but only production dependencies. The .gitignore reflects this and we have automated tooling to keep it up to date.

@siemhesda

Copy link
Copy Markdown
Contributor Author

I did a commit for the command

@wraithgar

Copy link
Copy Markdown
Contributor

Not sure why your changes aren't propagating when you update snapshots. Were there other files that didn't get committed?

@siemhesda

Copy link
Copy Markdown
Contributor Author

I also made a commit for npm run build -w doc that I had had not run before. How does it look now?

Comment thread tap-snapshots/test/lib/commands/publish.js.test.cjs

@wraithgar wraithgar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay looks like we got there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants