Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e6ad7f4c9c647e4a36da0b5c561efb286c4d3e34
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 29002ceb4ebdb60e85034d529d147d6a5b2cf34c
Choose a head ref
  • 11 commits
  • 3,485 files changed
  • 2 contributors

Commits on Jan 28, 2019

  1. deps: upgrade openssl sources to 1.1.1a 

    This updates all sources in deps/openssl/openssl with openssl-1.1.1a.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @sam-github @targos
    sam-github authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    c581b9a View commit details
    Browse the repository at this point in the history

  2. deps: fix gyp/gypi for openssl-1.1.1 

    Some of defines and cppflags in the build config of OpenSSL-1.1.1 were
moved to new attributes. Gyp and gypi file generations are needed to be
fixed to include them.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @shigeki @targos
    shigeki authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    e204399 View commit details
    Browse the repository at this point in the history

  3. deps: fix MacOS and Win build for OpenSSL-1.1.1 

    Because llvm on MacOS does not support AVX-512, asm files need to be limited to
AVX-2 support even when they are generated on Linux.  fake_gcc.pl returns the
fake llvm banner version for MacOS as if the assembler supports upto AVX-2.

For Windows, makefiles for nmake were updated in OpenSSL-1.1.1 and they are
rewritten into GNU makefile format by hand.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @shigeki @targos
    shigeki authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    0a0f15f View commit details
    Browse the repository at this point in the history

  4. deps: add s390 asm rules for OpenSSL-1.1.1 

    This is a floating patch against OpenSSL-1.1.1 to generate asm files
with Makefile rules.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @shigeki @targos
    shigeki authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    670f100 View commit details
    Browse the repository at this point in the history

  5. deps: add only avx2 configs for OpenSSL-1.1.1 

    OpenSSL-1.1.1 has new support of AVX-512 but AVX-2 asm files still need
to be generated for the older assembler support to keep backward
compatibilities.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @shigeki @targos
    shigeki authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    ad04d7b View commit details
    Browse the repository at this point in the history

  6. deps: fix for non GNU assembler in AIX 

    AIX has own assembler not GNU as that does not support --noexecstack.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @shigeki @targos
    shigeki authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    5225214 View commit details
    Browse the repository at this point in the history

  7. doc: fix assembler requirement for OpenSSL-1.1.1 

    Add new requirements of assembler version for AVX-512 support
in OpenSSL-1.1.1.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @shigeki @targos
    shigeki authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    5d5c528 View commit details
    Browse the repository at this point in the history

  8. deps: update archs files for OpenSSL-1.1.1a 

    `cd deps/openssl/config; make` updates all archs dependant files.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @sam-github @targos
    sam-github authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    d4ec110 View commit details
    Browse the repository at this point in the history

  9. tls: make ossl 1.1.1 cipher list throw error 

    Make OpenSSL 1.1.1 error during cipher list setting if it would have
errored with OpenSSL 1.1.0.

Can be dropped after our OpenSSL fixes this upstream.

See: openssl/openssl#7759

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @sam-github @targos
    sam-github authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    c34c569 View commit details
    Browse the repository at this point in the history

  10. tls: workaround handshakedone in renegotiation 

    `SSL_CB_HANDSHAKE_START` and `SSL_CB_HANDSHAKE_DONE` are called
sending HelloRequest in OpenSSL-1.1.1.
We need to check whether this is in a renegotiation state or not.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @shigeki @targos
    shigeki authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    6e80f6d View commit details
    Browse the repository at this point in the history

  11. test: assert on client and server side seperately 

    This gets better coverage of the codes, and is more explicit. It also
works around ordering differences in the errors produced by openssl.
The approach was tested with 1.1.0 and 1.1.1, as well as TLSv1.2 vs
TLSv1.3. OpenSSL 1.1.0 is relevant when node is built against a shared
openssl.

PR-URL: #25381
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Backport-PR-URL: #25688
    @sam-github @targos
    sam-github authored and targos committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    29002ce View commit details
    Browse the repository at this point in the history
Loading