Don't lint against Hooks after conditional throw#14040
Merged
Merged
Conversation
sophiebits
force-pushed
the
throw-before-hook
branch
from
b38a292 to
8c39ca3
Compare
acdlite
approved these changes
Oct 30, 2018
acdlite
left a comment
acdlite
left a comment
Collaborator
There was a problem hiding this comment.
Seems fine, with the caveat that I don't know much about ESLint plugins
Collaborator
Author
|
It's possible that |
Details of bundled changes.Comparing: 169f935...fcd4703 scheduler
Generated by 🚫 dangerJS |
Seems like this should be OK. Fixes react#14038. Now when tracking paths, we completely ignore segments that end in a throw. In https://eslint.org/docs/developer-guide/code-path-analysis I don't see a way to detect throws other than manually tracking them, so that's what I've done.
sophiebits
force-pushed
the
throw-before-hook
branch
from
8c39ca3 to
fcd4703
Compare
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
Seems like this should be OK. Fixes react#14038. Now when tracking paths, we completely ignore segments that end in a throw.
This was referenced Aug 14, 2019
This was referenced Aug 24, 2019
This was referenced Aug 30, 2019
This was referenced Sep 20, 2019
Open
[Snyk] Upgrade react-dom from 16.5.2 to 16.9.0
maxiplux/spring-security-react-ant-design-polls-app#3
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like this should be OK. Fixes #14038.
Now when tracking paths, we completely ignore segments that end in a throw.