This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] keep old network ids#149
Merged
andrewhsu merged 1 commit intoFeb 21, 2019
Merged
Conversation
for windows all networks are re-populated in the store during network controller initialization. In current version it also regenerate network Ids which may be referenced by other components and it may cause broken references to a networks. This commit avoids regeneration of network ids. Signed-off-by: Andrey Kolomentsev <andrey.kolomentsev@docker.com> (cherry picked from commit e017717) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Failure on PowerPC is unrelated, and should be fixed by #150 (I don't think a rebase is needed, as this PR only affects Windows) |
Member
Author
|
ping @ddebroy @fcrisciani @andrewhsu PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of moby#38580 for 18.09
for windows all networks are re-populated in the store during network controller initialization. In current version it also regenerate network Ids which may be referenced by other components and it may cause broken references to a networks. This commit avoids regeneration of network ids.