Skip to content

Add Cron.prev reverse iteration support#5786

Merged
fubhy merged 14 commits into
next-minorfrom
cron-prev-polish
Jan 7, 2026
Merged

Add Cron.prev reverse iteration support#5786
fubhy merged 14 commits into
next-minorfrom
cron-prev-polish

Conversation

@kitlangton

@kitlangton kitlangton commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Summary

  • add backward cron traversal with shared lookup tables and last-boundary resets
  • align DST handling while walking backward and add reverse sequence iterator
  • expand cron prev/next symmetry tests, DST overlap coverage, step/range backward cases, month/year wrap, and add changeset

Context

Based on @tmcw's fork branch https://github.com/tmcw/effect/tree/cron-prev ; rebased on main and tightened tests/edge cases.
Closes #5666.

Testing

  • pnpm vitest packages/effect/test/Cron.test.ts

@changeset-bot

changeset-bot Bot commented Nov 21, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 42e9d0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc Major
@effect/sql-clickhouse Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major
@effect/workflow Major
@effect/ai Major
@effect/ai-amazon-bedrock Major
@effect/ai-anthropic Major
@effect/ai-google Major
@effect/ai-openai Major
@effect/ai-openrouter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-bot effect-bot changed the base branch from main to next-minor November 21, 2025 21:08
@kitlangton kitlangton requested a review from fubhy November 21, 2025 21:31
@kitlangton

Copy link
Copy Markdown
Contributor Author

@copilot tell me I'm beautiful

Copilot AI commented Nov 21, 2025

Copy link
Copy Markdown

@kitlangton I've opened a new pull request, #5787, to work on those changes. Once the pull request is ready, I'll request review from you.

@effect-bot effect-bot force-pushed the next-minor branch 10 times, most recently from 6c3c7b6 to a75f668 Compare November 27, 2025 04:41
@effect-bot effect-bot force-pushed the next-minor branch 7 times, most recently from 5540156 to f752fc3 Compare December 13, 2025 05:00
@effect-bot effect-bot force-pushed the next-minor branch 5 times, most recently from 24ae504 to 6bc6da5 Compare December 23, 2025 17:40
@effect-bot effect-bot force-pushed the next-minor branch 6 times, most recently from 3819093 to d0dae5b Compare January 2, 2026 15:30
@tmcw

tmcw commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Any chance this can get merged? Would love to drop another dependency in favor of Effect.

@kitlangton

Copy link
Copy Markdown
Contributor Author

@fubhy YOU HAVE DECEIVED US.

@fubhy

fubhy commented Jan 7, 2026

Copy link
Copy Markdown
Member

OKOK I AM ON IT!

@fubhy fubhy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to team Cron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants