Plugin Foundation#43
Conversation
felixarntz
left a comment
There was a problem hiding this comment.
@jjgrainger Almost LGTM, just one tiny thing, and another observation to handle separately.
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @jjgrainger Left some nit-pick feedbacks
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @jjgrainger Left some nit-pick feedback.
- As per the issue acceptance criteria, the folder name is
testsand PR usedtest. which needs to be updated.
@mukeshpanchal27 the AC actually uses |
|
Thanks @jjgrainger for clarification. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
LGTM. Great work, @jjgrainger
* Add application files check * Add .phar extension and alphabetize the array * add .DS_Store to exclusion list * Updates * Abstract throw_error
Adds initial project files and directories.
SECURITY.md,CODE_OF_CONDUCT.mdandLICENSEwordpress/plugin-checknamespace, instead of10up/plugin-checkknowing this repo will be moved across at a later date.Closes #1