➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author sobolevn
Recipients AlexWaygood, JelleZijlstra, gvanrossum, kj, sobolevn
Date 2022-02-08.20:03:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1644350626.56.0.225939389842.issue46685@roundup.psfhosted.org>
In-reply-to
Content 
New features (like `Self` type and `Never` type), in my opinion, require some extra testing.

Things that were not covered:
- Inheritance from `Self`, only `type(Self)` is covered: https://github.com/python/cpython/blob/c018d3037b5b62e6d48d5985d1a37b91762fbffb/Lib/test/test_typing.py#L193-L196
- Equality and non-equality for `Self` and `Never`. We should be sure that `NoReturn` is not equal to `Never`, but they are equal to themselfs
- `get_type_hints` with `Never`
- `get_origin` with `Self` and `Never` types, it should return `None` for both cases
- (not exactly related) I've also noticed that this line is not covered at all: https://github.com/python/cpython/blob/c018d3037b5b62e6d48d5985d1a37b91762fbffb/Lib/typing.py#L725

Maybe there are some other cases? 

I will send a PR :)
History
Date User Action Args
2022-02-08 20:03:46sobolevnsetrecipients: + sobolevn, gvanrossum, JelleZijlstra, kj, AlexWaygood
2022-02-08 20:03:46sobolevnsetmessageid: <1644350626.56.0.225939389842.issue46685@roundup.psfhosted.org>
2022-02-08 20:03:46sobolevnlinkissue46685 messages
2022-02-08 20:03:46sobolevncreate